Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add namespaces for features #431

Merged
merged 10 commits into from
Aug 19, 2024

Conversation

FlayaN
Copy link
Collaborator

@FlayaN FlayaN commented Aug 18, 2024

Added namespaces for all features.

Each namespace is added in its own commit, so this PR can be merged without squash if wanted.

To see changes done hide the whitespace changes
image

@doodlum
Copy link
Owner

doodlum commented Aug 18, 2024

This is really cool. I think what we could do is in another PR at some point, the same for include files. That way we know where things come from and don't share a global scope. E.g. M_PI becomes Constants::PI

@FlayaN
Copy link
Collaborator Author

FlayaN commented Aug 18, 2024

This is really cool. I think what we could do is in another PR at some point, the same for include files. That way we know where things come from and don't share a global scope. E.g. M_PI becomes Constants::PI

Yeah that is the plan, just wanted to do it for features to start with!

@FlayaN FlayaN force-pushed the refactor-add-feature-shader-namespaces branch from b2db46f to 660cc99 Compare August 18, 2024 21:16
@FlayaN FlayaN force-pushed the refactor-add-feature-shader-namespaces branch from 660cc99 to 7e4ecde Compare August 18, 2024 22:26
@FlayaN FlayaN requested a review from doodlum August 18, 2024 22:30
@doodlum doodlum merged commit 78b8a3f into doodlum:dev Aug 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants