feat: PBR asset matching #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes to how PBR lighting works have been tested by multiple people and determined to be very close to the expected look, better than alternatives tests.
Changes vs dev, are that all PBR lighting is done in linear. And we assume that the vanilla diffuse texture has been premultiplied by the lambert diffuse function, which is (1.0 / PI). This explains why the lambert function is never applied in vanilla / why specular lighting is not multiplied by PI.
Therefore we remove a lot of multiplications by PI and divide the albedo by PI to match the vanilla diffuse brightness.