fix: fix missing directory ctd with DynamicCubeMap Creator #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a destination folder for the DynamicCubeMap Creator export does not exist then CS should not crash. Now: Create Folder if destination folder does not exist. Unable to create missing folder: log error File Object with same name exists: skips
|
LGTM |
alandtse
changed the title
alandtse
reviewed
Sep 10, 2024
alandtse
reviewed
Sep 10, 2024
Moved Texture creation and SaveToDDSFile inside try/catch block. This removed one boolean variable that had been used . No attempt is made to save a file if that filename exists (even an incorrect file object). As there are multiple types of exceptions including OS filesystem errors the catch was left as std::exception instead of multiple catch types and specific log messages.
|
Also once you've addressed comments, close them out and let us know this is ready to go. |
|
Logs actions and errors. Future: Add UI level notification |
alandtse
approved these changes
Sep 13, 2024
alandtse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a destination folder for the DynamicCubeMap Creator export does not exist then CS should not crash.
Now:
Create Folder if destination folder does not exist. Unable to create missing folder: log error
File Object with same name exists: skips