Sync with VR branch #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add advanced config option to dump shaders on startup.
Add the ability to adjust the default log level in imgui. Log level is read at plugin startup.
This revives previously commented statements and adds others.
Disabled checkboxes will be enabled while in trace of debug log level
By default, VR can only do grass. Flat can do more.
This includes fixing the runtime states of various classes locally and in commonlibng (see submodule). The majority of classes now take from commonlibng. I have one or two classes to move into ng.
Removes redundant code between two lights and shadowlights using a lambda processLights
Includes for local BSGraphics are left intact but could be removed.
FlayaN
pushed a commit
to FlayaN/skyrim-community-shaders
that referenced
this pull request
Aug 1, 2024
fix: fix runtime crash VR and fix constant indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be the better branch to sync since it's closer to your main. Please note I haven't reverted your VR specific changes like changing the default for cmake or the straight modification to the VR grass shader. However, this builds and works in SE/VR based on testing. I may make those changes anyway as I work through this.