Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core feature support #675

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat: add core feature support #675

merged 1 commit into from
Oct 21, 2024

Conversation

FlayaN
Copy link
Collaborator

@FlayaN FlayaN commented Oct 20, 2024

  • Created a virtual method that can be overridden for it to instead show up under Core Features group in menu
  • Zip folder with the file CORE them in the core CS zip file instead of their own zip file (also set for FG in this case)
  • Move feature Disable at Boot and Restore Defaults button to one line
  • Marked Dynamic Cubemaps and Extended Materials as core features

before:
image
image

after:
image
image

@FlayaN FlayaN mentioned this pull request Oct 20, 2024
55 tasks
@Pentalimbed
Copy link
Collaborator

Pentalimbed commented Oct 20, 2024

Personally, I'd make IsCore a virtual function like GetName, and separate zip specification from cpp code, because:

  1. It preserves the custom.
  2. Whether a feature is core or not should be hardcoded, not dependant on an external file.
  3. (Following 2) In case the ini file is missing, the core feature then becomes non-core and disappears in the menu, which is not what we want.

If separated, you can say just check if there is an empty CORE file in the directory and pack them in the main zip.

Copy link
Owner

@doodlum doodlum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd make IsCore a virtual function like GetName, and separate zip specification from cpp code, because:

  1. It preserves the custom.
  2. Whether a feature is core or not should be hardcoded, not dependant on an external file.
  3. (Following 2) In case the ini file is missing, the core feature then becomes non-core and disappears in the menu, which is not what we want.

If separated, you can say just check if there is an empty CORE file in the directory and pack them in the main zip.

@FlayaN FlayaN requested a review from doodlum October 20, 2024 19:57
@FlayaN FlayaN requested review from Pentalimbed and removed request for doodlum October 20, 2024 20:03
@FlayaN FlayaN dismissed doodlum’s stale review October 20, 2024 20:05

Was actually profjacks input

@doodlum doodlum merged commit 0215f5a into doodlum:dev Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants