Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VR): update clib with VR support for raindata #757

Merged

Conversation

FlayaN
Copy link
Collaborator

@FlayaN FlayaN commented Nov 18, 2024

  • Update clib with VR support for BGSShaderParticleGeometryData
  • Added clib util for fetching rain precipitation settingValue
  • Update wetness to use it
    Fixes VR broken raindrops #753

@FlayaN FlayaN changed the title build: update clib with VR support for raindata fix: update clib with VR support for raindata Nov 18, 2024
@FlayaN FlayaN changed the title fix: update clib with VR support for raindata fix(VR): update clib with VR support for raindata Nov 18, 2024
@FlayaN FlayaN mentioned this pull request Nov 18, 2024
@alandtse
Copy link
Collaborator

Are you maintaining a new fork of NG? I haven't seen any PRs.

@FlayaN
Copy link
Collaborator Author

FlayaN commented Nov 18, 2024

Are you maintaining a new fork of NG? I haven't seen any PRs.

@alandtse

Oh yeah I've been meaning to ask, do you have any plans to upstream from po3 soon? My plan was to create PRs to your fork as soon as that it done. Tried to do it myself but was a lot of changes so only cherry-picked 2 commits instead with some additions. I have 3 PRs as soon as you upstream. So only a temporary fork!

@doodlum doodlum merged commit da40478 into doodlum:dev Nov 18, 2024
9 checks passed
@alandtse
Copy link
Collaborator

alandtse commented Nov 18, 2024

There's no way to upstream ng to po3. Our structures are too different.

@FlayaN
Copy link
Collaborator Author

FlayaN commented Nov 18, 2024

I meant the other way :P po3 to ng, guess merge is the term i meant

@FlayaN
Copy link
Collaborator Author

FlayaN commented Nov 18, 2024

I meant the other way :P po3 to ng, guess merge is the term i meant

@alandtse ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VR broken raindrops
3 participants