chore: improve settings, remove PBR settings #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alandtse
changed the title
|
These changes don't look like settings changes. |
Removing the PBR settings was because I had to choose if I wanted to add the restore defaults and since we are probably removing anyway, made more sense. |
|
My point is your commit message is misleading. |
Please suggest what changes should be made. |
|
The pr title should say remove PBR settings or whatever. |
doodlum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If settings error they reset to default using a try catch loop. No more crashes.
Settings are relocated under the CommunityShaders folder. They could be under their own Settings folder in that, but that might be annoying. I think it may be good though considering we will probably split things up more.
Settings files are renamed to be clearer.
PBR settings removed, they were pretty much testing code.