Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group not loaded features in UI #824

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

FlayaN
Copy link
Collaborator

@FlayaN FlayaN commented Dec 6, 2024

image

Now groups not loaded features into it's own group in UI. This was done to cause less confusion for endusers why some features are grey

@FlayaN FlayaN force-pushed the not-loaded-features branch from 0ec42cd to 31736fb Compare December 6, 2024 23:54
@alandtse
Copy link
Collaborator

alandtse commented Dec 7, 2024

Hide unless in developer mode if you're going to create a special section.

@FlayaN
Copy link
Collaborator Author

FlayaN commented Dec 7, 2024

Hide unless in developer mode if you're going to create a special section.

It's only a filter of existing features, not adding any new items here. So that would be a scope creep, thats more into the terratory if we want to hide not loaded features or not. I want this PR to be just this filter.

@FlayaN FlayaN marked this pull request as draft December 7, 2024 00:08
@FlayaN
Copy link
Collaborator Author

FlayaN commented Dec 7, 2024

Just realized I need to fix the 0 case Fixed

@FlayaN FlayaN force-pushed the not-loaded-features branch from 31736fb to 375d026 Compare December 7, 2024 00:26
@FlayaN FlayaN marked this pull request as ready for review December 7, 2024 00:27
@doodlum doodlum merged commit 8c63855 into doodlum:dev Dec 7, 2024
3 checks passed
@alandtse
Copy link
Collaborator

alandtse commented Dec 7, 2024

I'm pretty sure by showing it still you will get the confused users so the point of this won't be accomplished but ready to be pleasantly surprised.

@doodlum
Copy link
Owner

doodlum commented Dec 7, 2024

To an extent, it is contradictory as a development project where we want users to feel involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants