Simplify parsing of AMENT_PREFIX_PATH
#489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current outside issue blocking our CI: |
haixuanTao
force-pushed
the
fix-ament-prefix-path
branch
from
0e14b75
to
03ad014
Compare
Merged
This PR simplify how ROS2 messages are parsed using dora. It will parse all messages included in the `AMENT_PREFIX_PATH` folder that has a path in the following format: `<package>/msg/<message>.msg`. Similarly for services it will be parsed as: `<package>/srv/<service>.srv`. It does not requires `.idl` anymore nor does it needs to be in the `ament_index`.
…e (package, message) Fix CI by ficing widestring proc_macro, fixing clippy, adding CI flag fix CI with minor changes
haixuanTao
force-pushed
the
fix-ament-prefix-path
branch
2 times, most recently
from
bb9fabb
to
9891517
Compare
|
Looks like something went wrong during rebasing. Commit 0676366 contains lots of unrelated changes.... |
phil-opp
reviewed
Apr 30, 2024
haixuanTao
force-pushed
the
fix-ament-prefix-path
branch
from
9891517
to
92e0edb
Compare
|
Thanks for catching the unwanted commit 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplify how ROS2 messages are parsed using dora.
It will parse all messages included in the
AMENT_PREFIX_PATHfolder that has a path in the following format:<package>/msg/<message>.msg.Similarly for services it will be parsed as:
<package>/srv/<service>.srv.It does not requires
.idlanymore nor does it needs to be in theament_index.Fixes: #481