GraphQL Yoga driver for NestJS GraphQL #2525

enisdenjo · 2023-03-02T15:58:04Z

Significant refactor and cleanup of https://github.com/enisdenjo/graphql-yoga-nestjs for v1.

TODO

Split federation things to separate pkg
Tests
Documentation
~~Must use npm for the example and exclude from pnpm workspace because hoisting breaks NestJS~~
Fixed by applying singletons in lockfile through pnpm hooks (b05137d)
Update NestJS GraphQL to v11
Apollo Federation compatibility tests (No tests found when using fedtest with pnpm apollographql/apollo-federation-subgraph-compatibility#406)

BREAKING CHANGES

No more subscriptionWithFilter in YogaBaseDriver.
YogaBaseDriver.yogaInstance has been renamed to YogaBaseDriver.yoga
YogaBaseDriver has been renamed to AbstractYogaDriver
Drop @envelop/apollo-server-errors, if you want to use it - supply it to the plugins yourself
graphql is now a peer dependency
graphql-yoga is now a peer dependency
installSubscriptionHandlers driver option has been dropped, please use the subscriptions
option
Apollo Federation v2 support
Apollo Federation driver has been moved to a separate package @graphql-yoga/nestjs-federation
Dropped support for @nestjs/graphql@v10, now at least v11 is required (Refactor schema generation to be independent of driver start nestjs/graphql#2435)
Minimum Node.js engine is v14

changeset-bot · 2023-03-02T15:58:08Z

🦋 Changeset detected

Latest commit: f14235d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@graphql-yoga/nestjs-federation	Major
@graphql-yoga/nestjs	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-03-02T16:01:03Z

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support

`_service`	🟢
`@key (single)`	🟢
`@key (multi)`	🟢
`@key (composite)`	🟢
`repeatable @key`	🟢
`@requires`	🟢
`@provides`	🟢
`federated tracing`	🟢

`@link`	🟢
`@shareable`	🟢
`@tag`	🟢
`@override`	🟢
`@inaccessible`	🟢
`@composeDirective`	🟢
`@interfaceObject`	🟢

Learn more:

github-actions · 2023-03-02T16:03:34Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@graphql-yoga/apollo-link`	`1.7.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/urql-exchange`	`1.7.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/common`	`3.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/graphiql`	`3.0.10-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`graphql-yoga`	`3.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/nestjs`	`1.0.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/nestjs-federation`	`1.0.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/node`	`3.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/plugin-apollo-inline-trace`	`1.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/plugin-apq`	`1.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/plugin-csrf-prevention`	`1.4.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/plugin-defer-stream`	`1.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/plugin-disable-introspection`	`0.7.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/plugin-graphql-sse`	`1.4.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/plugin-persisted-operations`	`1.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/plugin-prometheus`	`1.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/plugin-response-cache`	`1.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/plugin-sofa`	`1.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎
`@graphql-yoga/render-graphiql`	`3.8.0-alpha-20230328132821-f14235d8`	npm ↗︎ unpkg ↗︎

github-actions · 2023-03-02T16:03:43Z

❌ Benchmark Failed

Performance regression detected: it seems like your Pull Request adds some extra latency to GraphQL Yoga

If the performance regression is expected, please increase the failing threshold.

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 198480     ✗ 0    
     data_received................................: 812 MB  6.8 MB/s
     data_sent....................................: 40 MB   334 kB/s
     http_req_blocked.............................: avg=2.92µs   min=1.5µs   med=2.29µs  max=2.91ms  p(90)=3µs      p(95)=3.5µs   
     http_req_connecting..........................: avg=48ns     min=0s      med=0s      max=2.02ms  p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=839.1µs  min=384.1µs med=684.3µs max=73.55ms p(90)=1.15ms   p(95)=1.31ms  
       { expected_response:true }.................: avg=839.1µs  min=384.1µs med=684.3µs max=73.55ms p(90)=1.15ms   p(95)=1.31ms  
     ✓ { mode:graphql-jit }.......................: avg=677.93µs min=384.1µs med=580.2µs max=27.63ms p(90)=742.21µs p(95)=909.32µs
     ✗ { mode:graphql-no-parse-validate-cache }...: avg=1.2ms    min=827µs   med=1.09ms  max=23.16ms p(90)=1.34ms   p(95)=1.78ms  
     ✓ { mode:graphql-response-cache }............: avg=720.15µs min=438.2µs med=628.9µs max=17.65ms p(90)=801.97µs p(95)=968.28µs
     ✓ { mode:graphql }...........................: avg=875.26µs min=488.3µs med=742.9µs max=73.55ms p(90)=999.9µs  p(95)=1.3ms   
     http_req_failed..............................: 0.00%   ✓ 0          ✗ 99240
     http_req_receiving...........................: avg=50.17µs  min=23.3µs  med=41.5µs  max=15.23ms p(90)=63.2µs   p(95)=82.4µs  
     http_req_sending.............................: avg=22.49µs  min=8.9µs   med=12.9µs  max=15.3ms  p(90)=25.2µs   p(95)=33.9µs  
     http_req_tls_handshaking.....................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=766.43µs min=346.1µs med=619.4µs max=73.45ms p(90)=1.08ms   p(95)=1.22ms  
     http_reqs....................................: 99240   826.944888/s
     iteration_duration...........................: avg=1.19ms   min=644.2µs med=1.03ms  max=74ms    p(90)=1.52ms   p(95)=1.79ms  
     iterations...................................: 99240   826.944888/s
     vus..........................................: 1       min=1        max=1  
     vus_max......................................: 2       min=2        max=2

github-actions · 2023-03-02T16:03:59Z

💻 Website Preview

The latest changes are available as preview in: https://ffff465a.graphql-yoga.pages.dev

Moved from enisdenjo/graphql-yoga-nestjs#82.

# Conflicts: # pnpm-lock.yaml

enisdenjo mentioned this pull request Mar 2, 2023

v1 enisdenjo/graphql-yoga-nestjs#82

Closed

enisdenjo force-pushed the nestjs branch 2 times, most recently from ca8f02b to d337489 Compare March 3, 2023 14:03

enisdenjo force-pushed the nestjs branch 2 times, most recently from 4a716b4 to ca0ee01 Compare March 22, 2023 17:24

enisdenjo added 20 commits March 24, 2023 16:18

move

738920b

Moved from enisdenjo/graphql-yoga-nestjs#82.

changeset

d0c0c68

prettier tslib and stuff

13c0039

change url

7181a9f

prettier

b9dff4d

eventually split federation

444cfac

nestjs federation compatibility

0a19202

match deps with plugin pkg

c495ff2

npm for nestjs apollo fed

04fb2c6

update sse snapshots

0437170

federation

1fc68e7

ci test and report to job

1a4c86c

better summary

106c351

nestjs type module

9a76a42

separate nestjs federation package

fc13201

changeset for nestjs-federation

db58bd5

nestjs is a dep

daf6024

use pnpm for apollo fed compatibility and monkey patch pnpm-lock

e79a135

"example" singular name

eaf6d3b

pnpm build for apollo fed

11f6508

enisdenjo added 2 commits March 24, 2023 16:20

no working dir for tests

16e9c75

lock to 1.2.1

1445d69

enisdenjo force-pushed the nestjs branch from 97aad3b to 1445d69 Compare March 24, 2023 15:21

enisdenjo added 9 commits March 24, 2023 16:23

downgrade and lock class-transformer

40b0021

federation-subgraph-compatibility lib as singleton

d20cf65

apollo-subgraph lib match vers and singleton

bd20234

clarify

450c7d8

remove unnecessary things

1a9fdfd

bump nestjs graphql to v11

fe3d83c

no mergewithschema in nestjs graphql v11

e3c9f6b

generate schema for federation

e73f548

update documentation

3dad75f

enisdenjo marked this pull request as ready for review March 24, 2023 18:06

enisdenjo added 2 commits March 25, 2023 14:03

use gh action for federation, but no token = no comment

f8d8459

Merge branch 'main' into nestjs

39bfc70

# Conflicts: # pnpm-lock.yaml

ardatan approved these changes Mar 25, 2023

View reviewed changes

enisdenjo added 3 commits March 25, 2023 14:51

add use apollo inline trace

1ae0f0e

Merge branch 'main' into nestjs

77c671f

# Conflicts: # pnpm-lock.yaml

state braking changeset in changeset

f14235d

enisdenjo merged commit 41f4a54 into main Mar 28, 2023

enisdenjo deleted the nestjs branch March 28, 2023 13:38

theguild-bot mentioned this pull request Mar 28, 2023

Upcoming Release Changes #2596

Merged

This was referenced Mar 28, 2023

Upcoming driver API change enisdenjo/graphql-yoga-nestjs#84

Closed

Federation code first example requires additional envelop plugin enisdenjo/graphql-yoga-nestjs#80

Closed

Use sofa plugin enisdenjo/graphql-yoga-nestjs#83

Closed

theguild-bot mentioned this pull request Apr 20, 2023

Project Roadmap #2700

Open

This was referenced May 7, 2024

Project Roadmap #3260

Closed

Project Roadmap #3261

Closed

This was referenced May 23, 2024

Project Roadmap #3287

Open

Project Roadmap #3288

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GraphQL Yoga driver for NestJS GraphQL #2525

GraphQL Yoga driver for NestJS GraphQL #2525

enisdenjo commented Mar 2, 2023 •

edited

Loading

changeset-bot bot commented Mar 2, 2023 •

edited

Loading

github-actions bot commented Mar 2, 2023 •

edited

Loading

github-actions bot commented Mar 2, 2023 •

edited

Loading

github-actions bot commented Mar 2, 2023 •

edited

Loading

github-actions bot commented Mar 2, 2023 •

edited

Loading

GraphQL Yoga driver for NestJS GraphQL #2525

GraphQL Yoga driver for NestJS GraphQL #2525

Conversation

enisdenjo commented Mar 2, 2023 • edited Loading

TODO

BREAKING CHANGES

changeset-bot bot commented Mar 2, 2023 • edited Loading

🦋 Changeset detected

github-actions bot commented Mar 2, 2023 • edited Loading

Apollo Federation Subgraph Compatibility Results

github-actions bot commented Mar 2, 2023 • edited Loading

🚀 Snapshot Release (alpha)

github-actions bot commented Mar 2, 2023 • edited Loading

❌ Benchmark Failed

github-actions bot commented Mar 2, 2023 • edited Loading

💻 Website Preview

enisdenjo commented Mar 2, 2023 •

edited

Loading

changeset-bot bot commented Mar 2, 2023 •

edited

Loading

github-actions bot commented Mar 2, 2023 •

edited

Loading

github-actions bot commented Mar 2, 2023 •

edited

Loading

🚀 Snapshot Release (`alpha`)

github-actions bot commented Mar 2, 2023 •

edited

Loading

github-actions bot commented Mar 2, 2023 •

edited

Loading