Refactor schema generation to be independent of driver start #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarsonF
force-pushed
the
refactor/schema-generation-hook
branch
from
af46747 to
9f8bc82
Compare
CarsonF
commented
Oct 5, 2022
| public async generateSchema( | ||
| options: MercuriusDriverConfig, | ||
| ): Promise<GraphQLSchema> { | ||
| return new GraphQLSchema({}); |
There was a problem hiding this comment.
Since gateways don't generate a schema, I stubbed it here & omitted below. Same for apollo gateway.
If this feels hacky, I could change return type to be nullable.
CarsonF
force-pushed
the
refactor/schema-generation-hook
branch
from
9f8bc82 to
5903794
Compare
|
I think this fixes a bug I'm dealing with when trying to use |
4 tasks
CarsonF
force-pushed
the
refactor/schema-generation-hook
branch
from
5903794 to
6408c1f
Compare
|
LGTM |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Schema generation is done as apart of the driver start method and is only done if an http adapter is present.
Issue Number: #2433
What is the new behavior?
Schema generation is done before the driver start. It is done regardless of the presence of an http adapter.
Does this PR introduce a breaking change?
Other information