Add bluetooth-central key to README.md #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mikolak
reviewed
Apr 7, 2021
mikolak
approved these changes
Apr 8, 2021
mikolak
pushed a commit
that referenced
this pull request
Apr 13, 2021
* Work in progress * lib/** nullability compliant; added linter exceptions for string single quotes and pedantic local variable type rule * Example:: updated to nullsafe-ready dependencies * Example:: nullsafety + refactor WIP * Example:: nullsafe ready * Example/test:: nullsafe ready * test:: using new mocking mechanism additional fixes * Java: added some null checks to make the calls to stop and destroy reentrant * Example:: additional cleanup and refactor Lib:: enchanced error handling, refined nullability on certain types * TestFix:: the injected manager instance is not part of the Characteristic POD so should be ignored when checking for equallity * ble_error seem to have rather nullable fields * TestFix: little refactor on characteristic_mixin regarding clearity and type annotations * TestFix:: lib_core_test:: tests now passing * Example:: removed comment-disabled code * Test:: all tests Passing now! 🎉 * Enhanced BleError nullability, so that reason always has a default value; made fields final * Travis fix * disabled analysis for tests * Travis:: still fixing ios build * vscode:: stopped tracking settings file * travis:: removed my additions to ios example script * Characteristic:: Service field is now final * gitignored andoid related staff xcode noise * Add bluetooth-central key to README.md (#562) * Add bluetooth-central key to README.md Based on #530 * Update README.md * Travis: updated xcode version to 12.2 * BleError:: default reason text added * ScanResult:: added final qualifiers isConnectable is back to nullable since it's only available on iOS on android it will be null which does not mean false!! * CharacteristicsMixin:: _parseCharacteristicWithValueWithTransactionIdResponse():: signature is now type safe moved the rawJsonValue String checking to the caller side * Test:: removed dummy print * ScanningMixin:: _prepareScanEventsStream() renamed to just _scanEvents also _resetScanEvents introduced to null the underlying scream out * ScanningMixin:: small refinement on naming stuff * Characteristic:: refactor on Futures to always complete with something even if withResponse is false additional type safety on invokeMethod calls * Revert "Characteristic:: refactor on Futures to always complete with something even if withResponse is false" This reverts commit 86dafd6. Co-authored-by: Yauheni Pakala <evgeniy.pakalo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #530