Nullsafety #586

okocsis · 2021-04-01T08:08:29Z

Hey, guys! I've made a lot of effort to port the dart codebase to a nullsafe environment. I would appreciate someone taking a look at it.

known issues:
-not all of the test are compiling, although I've tried to make it work I've even ported some of the mocks to the new generated mocking scheme. FIXME: I think many of the test should be retired, in favour of general nullsafety. Please help me on that.
-there was a bleadapter lifecycle fiasco, because the DevicesBloc destroyed the client on dispose(), making the internal adapter unreachable, after going to detail view. Although I have attempted to fix this by just removing the destroy client call from DevicesBloc.dispose() but I'm just not certain this was the right solution in terms of good design.

Thanks for taking the time!

Fixes #556

CLAassistant · 2021-04-01T08:08:34Z

All committers have signed the CLA.

added linter exceptions for string single quotes and pedantic local variable type rule

additional fixes

…entrant

Lib:: enchanced error handling, refined nullability on certain types

…stic POD so should be ignored when checking for equallity

…nd type annotations

…lue; made fields final

mikolak

Just some early feedback as I'm on 11/51 files - I'll finish it tomorrow. Looks nice so far, thanks for the PR!

.vscode/settings.json

.travis.yml

lib/ble_manager.dart

lib/characteristic.dart

xcode noise

* Add bluetooth-central key to README.md Based on dotintent#530 * Update README.md

mikolak

Got a few questions and a change request, but other than that looks OK!

example/ios/Runner.xcodeproj/project.pbxproj

lib/characteristic.dart

lib/error/ble_error.dart

lib/scan_result.dart

lib/src/bridge/characteristics_mixin.dart

lib/src/bridge/scanning_mixin.dart

test/src/bridge/lib_core_test.dart

added final qualifiers isConnectable is back to nullable since it's only available on iOS on android it will be null which does not mean false!!

_parseCharacteristicWithValueWithTransactionIdResponse():: signature is now type safe moved the rawJsonValue String checking to the caller side

okocsis · 2021-04-08T21:58:27Z

@mikolak
Okay so, it seems the new xcode image did the trick for travis, now phase two passes as well, but still fails on phase three package-analysis as follows:
"package-analysis
It seems that this action doesn't have the required permissions to call the GitHub API with the token you gave. This can occur if this repository is a fork, as in that case GitHub reduces the GITHUB_TOKEN's permissions for security reasons. Consequently, no report will be made on GitHub. Check this issue for more information: axel-op/dart-package-analyzer#2"

I don't know how to fix this one mate.

mikolak · 2021-04-09T07:35:11Z

Yeah, it's because it's a PR from a fork instead of a MR from this repo - don't mind.

lib/src/bridge/scanning_mixin.dart

also _resetScanEvents introduced to null the underlying scream out

lib/src/bridge/scanning_mixin.dart

lib/src/bridge/characteristics_mixin.dart

…g even if withResponse is false additional type safety on invokeMethod calls

mikolak

I appreciate your work, but please, revert the last commit. Native client has to either return characteristic or error and I'd rather have a null pointer exception thrown than some custom exception that does not give the API consumer any insight or returning an invalid default value.

There's a bug where the response is not properly returned on Android, but it's a multilayer issue that originates in Android's MBA, any changes to interface will be done along with fixing it.

Changes to the mixins are unrelated to this PR and should be in a separate PR.

Summing up: thanks for all the work on null safety! ❤️ Please, run the formatter in scanning_mixin.dart and revert commit 86dafd6 (Characteristic:: refactor on Futures to always complete...) and I'll merge it! 🙂

lib/src/bridge/bluetooth_state_mixin.dart

lib/service.dart

lib/src/_managers_for_classes.dart

lib/peripheral.dart

lib/characteristic.dart

lib/src/bridge/bluetooth_state_mixin.dart

lib/src/bridge/characteristics_mixin.dart

…something even if withResponse is false" This reverts commit 86dafd6.

# Conflicts: # lib/src/bridge/lib_core.dart

mikolak

A few minors, but I'll take care of those myself. Thank you very much for the PR!

lib/src/bridge/characteristics_mixin.dart

lib/src/internal_ble_manager.dart

This was referenced Apr 1, 2021

Still maintained? #581

Open

Null-Safety migration #556

Closed

okocsis added 9 commits April 1, 2021 10:48

Work in progress

a64021c

lib/** nullability compliant;

cd829b2

added linter exceptions for string single quotes and pedantic local variable type rule

Example:: updated to nullsafe-ready dependencies

44cf93f

Example:: nullsafety + refactor WIP

7cff4d4

Example:: nullsafe ready

991473f

Example/test:: nullsafe ready

fdac568

test:: using new mocking mechanism

5ba2668

additional fixes

Java: added some null checks to make the calls to stop and destroy re…

44cb104

…entrant

Example:: additional cleanup and refactor

67f1b5a

Lib:: enchanced error handling, refined nullability on certain types

okocsis force-pushed the nullsafety branch from 35cf8fc to 67f1b5a Compare April 1, 2021 08:53

okocsis added 10 commits April 5, 2021 14:12

TestFix:: the injected manager instance is not part of the Characteri…

a3277e7

…stic POD so should be ignored when checking for equallity

ble_error seem to have rather nullable fields

ae7d4dc

TestFix: little refactor on characteristic_mixin regarding clearity a…

8b1175b

…nd type annotations

TestFix:: lib_core_test:: tests now passing

b58f8a0

Example:: removed comment-disabled code

682260b

Test:: all tests Passing now! 🎉

2292ffc

Enhanced BleError nullability, so that reason always has a default va…

ca0cd3c

…lue; made fields final

Travis fix

46aa6bf

disabled analysis for tests

50cb727

Travis:: still fixing ios build

2b7979b

mikolak self-requested a review April 7, 2021 12:56

mikolak reviewed Apr 7, 2021

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

lib/ble_manager.dart Show resolved Hide resolved

lib/characteristic.dart Outdated Show resolved Hide resolved

lib/characteristic.dart Show resolved Hide resolved

okocsis and others added 5 commits April 7, 2021 21:15

vscode:: stopped tracking settings file

72f30f2

travis:: removed my additions to ios example script

b486789

Characteristic:: Service field is now final

5f5c576

gitignored andoid related staff

5f68124

xcode noise

Add bluetooth-central key to README.md (dotintent#562)

1da3feb

* Add bluetooth-central key to README.md Based on dotintent#530 * Update README.md

mikolak added this to the 3.0.0 milestone Apr 8, 2021

mikolak requested changes Apr 8, 2021

View reviewed changes

okocsis added 6 commits April 8, 2021 23:12

Travis: updated xcode version to 12.2

56756e1

Merge commit '1da3feb70ed4f853145049fe3c5c4ec16080b287' into nullsafety

9d148b6

BleError:: default reason text added

9bd3e05

ScanResult::

5442bfa

added final qualifiers isConnectable is back to nullable since it's only available on iOS on android it will be null which does not mean false!!

CharacteristicsMixin::

fc130ba

_parseCharacteristicWithValueWithTransactionIdResponse():: signature is now type safe moved the rawJsonValue String checking to the caller side

Test:: removed dummy print

0d040db

mikolak mentioned this pull request Apr 9, 2021

Change ScanResult#isConnectable from nullable boolean to non-nullable enum #588

Open

okocsis commented Apr 10, 2021

View reviewed changes

lib/src/bridge/scanning_mixin.dart Show resolved Hide resolved

ScanningMixin:: _prepareScanEventsStream() renamed to just _scanEvents

b47cce9

also _resetScanEvents introduced to null the underlying scream out

mikolak requested changes Apr 11, 2021

View reviewed changes

lib/src/bridge/scanning_mixin.dart Outdated Show resolved Hide resolved

lib/src/bridge/scanning_mixin.dart Outdated Show resolved Hide resolved

ScanningMixin:: small refinement on naming stuff

c9c8d60

okocsis commented Apr 12, 2021

View reviewed changes

lib/src/bridge/characteristics_mixin.dart Show resolved Hide resolved

Characteristic:: refactor on Futures to always complete with somethin…

86dafd6

…g even if withResponse is false additional type safety on invokeMethod calls

mikolak requested changes Apr 12, 2021

View reviewed changes

okocsis added 2 commits April 13, 2021 08:20

Revert "Characteristic:: refactor on Futures to always complete with …

a46482d

…something even if withResponse is false" This reverts commit 86dafd6.

Merge commit 'aaa2009274a0b6c48a0eeae7565143f87b89ee2c' into nullsafety

d2fc7de

# Conflicts: # lib/src/bridge/lib_core.dart

mikolak approved these changes Apr 13, 2021

View reviewed changes

mikolak merged commit 1beac74 into dotintent:develop Apr 13, 2021

This was referenced Nov 18, 2021

Null safety feature request #600

Open

Request support the null-safety #598

Open

flutter_ble_lib deprecated #613

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nullsafety #586

Nullsafety #586

okocsis commented Apr 1, 2021 •

edited by mikolak

Loading

CLAassistant commented Apr 1, 2021 •

edited

Loading

mikolak left a comment

mikolak left a comment

okocsis commented Apr 8, 2021

mikolak commented Apr 9, 2021

mikolak left a comment •

edited

Loading

mikolak left a comment

Nullsafety #586

Nullsafety #586

Conversation

okocsis commented Apr 1, 2021 • edited by mikolak Loading

CLAassistant commented Apr 1, 2021 • edited Loading

mikolak left a comment

Choose a reason for hiding this comment

mikolak left a comment

Choose a reason for hiding this comment

okocsis commented Apr 8, 2021

mikolak commented Apr 9, 2021

mikolak left a comment • edited Loading

Choose a reason for hiding this comment

mikolak left a comment

Choose a reason for hiding this comment

okocsis commented Apr 1, 2021 •

edited by mikolak

Loading

CLAassistant commented Apr 1, 2021 •

edited

Loading

mikolak left a comment •

edited

Loading