Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #30282

Closed
wants to merge 3 commits into from
Closed

Update index.md #30282

wants to merge 3 commits into from

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Sep 8, 2023

Fixes #30281


Internal previews

📄 File 🔗 Preview link
aspnetcore/fundamentals/logging/index.md Logging in .NET Core and ASP.NET Core

@Rick-Anderson Rick-Anderson marked this pull request as ready for review September 8, 2023 19:09
@Rick-Anderson
Copy link
Contributor Author

@cijothomas what about moving it to the very bottom of the file under it's own H2? Doesn't the comment still apply?

If not, happy to remove the note.

@cijothomas
Copy link
Contributor

I'd suggest removing it now.

(once we decide to show how to do the logging even before DI/host is ready, then we need to show LoggerFactory.Create to create a alternate pipeline. When we add that, this Note can be brought back.)

@Rick-Anderson
Copy link
Contributor Author

Moved to #30288

@Rick-Anderson Rick-Anderson deleted the Rick-Anderson-patch-8 branch September 8, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove note
3 participants