Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logger /7 #30288

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix logger /7 #30288

merged 2 commits into from
Sep 8, 2023

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Sep 8, 2023

Fixes #30281


Internal previews

📄 File 🔗 Preview link
aspnetcore/fundamentals/logging/index.md Logging in .NET Core and ASP.NET Core

@Rick-Anderson Rick-Anderson marked this pull request as ready for review September 8, 2023 23:09
@Rick-Anderson
Copy link
Contributor Author

@cijothomas removed note. It's now in a comment so won't show. But what about folks that call loggerfactory.create? Shouldn't they be warned?

I could also removed the commented out note if it's inaccurate.

@Rick-Anderson Rick-Anderson merged commit 7b9118b into main Sep 8, 2023
2 checks passed
@Rick-Anderson Rick-Anderson deleted the log.create branch September 8, 2023 23:11
@Rick-Anderson Rick-Anderson mentioned this pull request Sep 8, 2023
@cijothomas
Copy link
Contributor

But what about folks that call loggerfactory.create? Shouldn't they be warned?

Why would someone do that in asp.net core? I understand previously people did it, but that could be because this doc itself referring it! Now that we removed it, I don't think we need to give that warning.

Will open a separate issue to help answer the question "what about logging before DI is ready?", with the answer to it as well (and that involves LoggerFactory.Create, and hence should come with the warning!)

We are waiting for the OpenTelemetry docs to clarify it first, and then come back and fix it right here! open-telemetry/opentelemetry-dotnet#4821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove note
2 participants