Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASP.NET Core logging example #4821

Merged
merged 26 commits into from
Sep 15, 2023

Conversation

reyang
Copy link
Member

@reyang reyang commented Sep 1, 2023

Still need to update the *.sln file and some README files.

@reyang reyang requested a review from a team September 1, 2023 23:08
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #4821 (f95395f) into main (9139b72) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4821   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files         293      293           
  Lines       12028    12028           
=======================================
+ Hits        10094    10095    +1     
+ Misses       1934     1933    -1     

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I personally don't prefer showing Scopes, ParseStateValues in the getting-started guide, but no blockers.


What does the above program do?

The program has added OpenTelemetry as a [logging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: mention we cleared all existing providers?

@Kielek
Copy link
Contributor

Kielek commented Sep 12, 2023

@reyang, not directly related to this PR, but it will be great to propagate your example (with some description) also to https://opentelemetry.io/docs/instrumentation/net/manual/

@cijothomas
Copy link
Member

@reyang, not directly related to this PR, but it will be great to propagate your example (with some description) also to https://opentelemetry.io/docs/instrumentation/net/manual/

that particular page need a lot of other fixes too!

@reyang
Copy link
Member Author

reyang commented Sep 12, 2023

@reyang, not directly related to this PR, but it will be great to propagate your example (with some description) also to https://opentelemetry.io/docs/instrumentation/net/manual/

I know, I think the 1st step is that we agree on a good example (current we don't have a good example) and that's what this PR is about.

Copy link
Contributor

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

CC @noahfalk @samsp-msft if having any more comments.

Copy link

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one suggestion inline

docs/logs/getting-started-aspnetcore/Program.cs Outdated Show resolved Hide resolved
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
@utpilla utpilla merged commit e9d0e2b into open-telemetry:main Sep 15, 2023
49 checks passed
@davidfowl
Copy link
Contributor

Maybe this is by design but clearing all of the loggers clears:

  • The event log logger on windows (there's no console on IIS)
  • The console logger (but we add a replacement one)
  • The event source logger (so logs can't be collected with etw/event pipe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants