-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ASP.NET Core logging example #4821
Add ASP.NET Core logging example #4821
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4821 +/- ##
=======================================
Coverage 83.92% 83.92%
=======================================
Files 293 293
Lines 12028 12028
=======================================
+ Hits 10094 10095 +1
+ Misses 1934 1933 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I personally don't prefer showing Scopes, ParseStateValues in the getting-started guide, but no blockers.
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
|
||
What does the above program do? | ||
|
||
The program has added OpenTelemetry as a [logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: mention we cleared all existing providers?
@reyang, not directly related to this PR, but it will be great to propagate your example (with some description) also to https://opentelemetry.io/docs/instrumentation/net/manual/ |
that particular page need a lot of other fixes too! |
I know, I think the 1st step is that we agree on a good example (current we don't have a good example) and that's what this PR is about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
CC @noahfalk @samsp-msft if having any more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo one suggestion inline
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
Maybe this is by design but clearing all of the loggers clears:
|
Still need to update the *.sln file and some README files.