-
-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise heuristic for initial jitting. #1949
Revise heuristic for initial jitting. #1949
Conversation
Increase the magic limit to 10s per dotnet#1780. Also use the "1.5" criteria for retry so we don't have odd threshold where initial jitting is a bit faster than IterationTime but not fast enough to trigger the multi action engine.
I get some local test failures so this may be missing something. Still evaluating this locally to make sure it does what I expect. |
Looks like this does what I'd expect. On one problematic test, the initial jitting for OSR is 208 ms, iteration time is 250 ms, and so with the change in this PR, we give it one more try, see it is actually much shorter, pick a reasonable number of iterations. MAIN is slower so gets a retry w/o these changes.
Default behavior w/o the change -- no retry for OSR, OSR looks like it has a massive regression, but we're not comparing apples to apples.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @AndyAyersMS !
Increase the magic limit to 10s per #1780.
Also use the "1.5" criteria for retry so we don't have odd threshold
where initial jitting is a bit faster than IterationTime but not fast
enough to trigger the multi action engine.