-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting back on track #1288
Closed
Closed
Getting back on track #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial NUKE prototype * First iteration of NUKE is done * Add a test target * Attempt one at updating the CI workflow * Attempt two at CI * Update global.json * Update build.yml * Update Silk.NET.NUKE.csproj * Disable SilkTouch debug dump, checkout recursively * Only test projects that have tests in the name .NET insists on building everything again for some reason * Stop deleting packages before pushing them * Try adding Android in the loop * Stop building libsilkdroid in CI (NDK issue) * NUKE is complete * Apply suggestions from code review Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com> Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com>
* Add some log messages to find out what's going on * Fix build * Adjust the pipeline * Zero what? Elephants? * Update build.yml * Ok seriously what is going on * Maybe it's a path thing? * Ohhhhh * Comment out the cwd artifact for now, will clean later * Commit finished NUKE build system * Commit finished build pipeline * There was a reason pack and push were separate
* Add args and be more tolerant of failures * Initial bindings with no COM, initial COM support in BuildTools * Complete Direct3D 11 and DXGI bindings * Start D3D12 work, move D3DCommon into Silk.NET.Core * Add d3d11shader.h, BuildTools bug fixes * Finish D3D12 bindings, add ComPtr & ComObject * Direct3D 9 Bindings * DXC and D3DCompiler bindings * Push (disabled) config for Direct2D * NUKE fixes * Continued * Binder improvements * More COM-related improvements * Revert SDL generator overwrite * Add XInput and XAudio * Finishing touches * Update src/Microsoft/Silk.NET.DXGI/DXGILibraryNameContainer.cs Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com> * GUIDs * Remove ZeroStart now it's no longer used Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com>
Merge pull request #418 from Ultz/hotfix/mar21-fixes
* Update README.md * Update license headers * Update everything else including CoC * Update copyright notices based on guidance * Create .gitattributes * Use LF in BuildTools * Use LF everywhere * Update contributing guides for WIP -> draft PR
Coalesce the NativePackages and SilkExtensions repositories
* Remove SDL mirror * Add the real SDL, fix generator paths * Regenerate D3D9 and SDL for 64-bit (build will probably fail) * Fix build errors * Fix fusion reactor not respecting desired names * Update Windows and Linux binary * Update libsilkdroid * Update macOS binary * Update iOS binary * This is the April 2021 Update (v2.3.0)
) * Add helper for making XrGraphicsBindingOpenGL* instances, start XR demo * Fix OpenXR flags being 32-bit not 64-bit, "almost" working OpenXR demo * Pushing latest demo - crosseyed is gone, replaced with weird fov thing * Add maths helpers, is this progress I don't even know anymore * Commit before rewrite * Scrap the demo * Stop us forgetting to ship bindings! * Add missing bindings to SLN and missing typemaps, update changelog * Update src/Core/Silk.NET.Core/Native/SilkMarshal.cs Co-authored-by: Kai Jellinghaus <contact@kaij.tech> * Bindings updates, fix release notes * Update Silk.NET.sln Co-authored-by: Kai Jellinghaus <contact@kaij.tech>
* Start of Code Signing * Remove Ultz.Native from the filelist
* Update deploy.yml * Sign one at a time maybe? * It worked, fixes for PR * cont'd
* Initial pass of adding .NET 6 support for sustaining * Get packaging working properly (afiak) * lol * SilkTouch: Stop making managed conv assumptions (.NET 5+), short names * Triangle on .NET 6 on Android now works * Fix old android lab app for fullscreen * Fix bad ifdef * CI fix? * Review fixes
* Stop always generating & building legacy solutions * Fixed broken references Co-authored-by: ThomasMiz <32400648+ThomasMiz@users.noreply.github.com>
* Build improvements & dynamic Windows SDK resolution (backport from 3.0) * Changes to some code formatting * Fix build errors * Fix build error * Enhanced typedef-powered renaming * Fix #652 * Marshal generic pointers in COM vtable wrapper functions * String generation improvements (fixes #630) * Sanity check, remove JetBrains.Annotations
* Packaging improvements, NuGet readmes, and 2.10 release notes * Fix GitHub README rendering issues * Attempt to fix whitespace * push push push push push push push * Actually fix whitespace * Update common.props * Update Directory.Build.props
* Remove Legacy Xamarin * NUKE overhaul * Get libsilkdroid building again * Attempt to fix build * Actually check in the aar
* Regenerate bindings * Release notes * Apply duct tape
* Adding public API to all manual projects * Add `nuke shipapi`, `nuke ensureapideclared`, and `nuke declareapi` * Attempt to make GitHub talk to you * Add some logging, fix a potential regex issue * Actually pass the GitHub Token * The code was correct the first time * Fix basic logic * Try give the token more permissions? * PR target * Let's hope this PR mechanism works? Can't test until merged now! * Install workload as well * Make BuildTools exempt from public API
* Start working with native builds * gh actions now? * now? * Actually get the submodules... * It now actually kinda does something * Save artifacts for testing * Not the prettiest, but may actually work * Maybe now I actually get the artifacts * Typo * What about now * Now lets put files in the right place * Maybe this is a bit nicer now * Apply suggestions from code review Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com> * Lock glfw to latest release Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.3.0 to 17.4.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.3.0...v17.4.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Statiq.App](https://github.com/statiqdev/Statiq.Framework) from 1.0.0-beta.62 to 1.0.0-beta.65. - [Release notes](https://github.com/statiqdev/Statiq.Framework/releases) - [Changelog](https://github.com/statiqdev/Statiq.Framework/blob/main/RELEASE.md) - [Commits](statiqdev/Statiq.Framework@v1.0.0-beta.62...v1.0.0-beta.65) --- updated-dependencies: - dependency-name: Statiq.App dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `RoslynPackageVersion` from 4.2.0 to 4.4.0. Updates `Microsoft.CodeAnalysis.CSharp` from 4.2.0 to 4.4.0 - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v4.2.0...Visual-Studio-2019-Version-16.0-Preview-4.4) Updates `Microsoft.CodeAnalysis.CSharp.Workspaces` from 4.2.0 to 4.4.0 - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v4.2.0...Visual-Studio-2019-Version-16.0-Preview-4.4) Updates `Microsoft.CodeAnalysis.Workspaces.MSBuild` from 4.2.0 to 4.4.0 - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v4.2.0...Visual-Studio-2019-Version-16.0-Preview-4.4) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.CodeAnalysis.CSharp.Workspaces dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.CodeAnalysis.Workspaces.MSBuild dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `MsExtensionNugetVersion` from 6.0.0 to 7.0.0. Updates `Microsoft.Extensions.FileSystemGlobbing` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v7.0.0) Updates `Microsoft.Extensions.Logging.Abstractions` from 5.0.0 to 7.0.0 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v5.0.0...v7.0.0) Updates `Microsoft.Extensions.Configuration.Abstractions` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v7.0.0) Updates `Microsoft.Extensions.Options` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v7.0.0) Updates `Microsoft.Extensions.Logging.Console` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v7.0.0) Updates `Microsoft.Extensions.Configuration.EnvironmentVariables` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v7.0.0) Updates `Microsoft.Extensions.Hosting.Abstractions` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v7.0.0) Updates `Microsoft.Extensions.DependencyInjection` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v7.0.0) Updates `Microsoft.Extensions.Logging` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v7.0.0) --- updated-dependencies: - dependency-name: Microsoft.Extensions.FileSystemGlobbing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging.Abstractions dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.Abstractions dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Options dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging.Console dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.EnvironmentVariables dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Hosting.Abstractions dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.DependencyInjection dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>
Bumps [Microsoft.CodeAnalysis.CSharp.Scripting](https://github.com/dotnet/roslyn) from 4.3.1 to 4.4.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits/Visual-Studio-2019-Version-16.0-Preview-4.4) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp.Scripting dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Microsoft.Build.Framework](https://github.com/dotnet/msbuild) from 16.10.0 to 17.4.0. - [Release notes](https://github.com/dotnet/msbuild/releases) - [Changelog](https://github.com/dotnet/msbuild/blob/main/documentation/Changelog.md) - [Commits](https://github.com/dotnet/msbuild/commits) --- updated-dependencies: - dependency-name: Microsoft.Build.Framework dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [System.Collections.Immutable](https://github.com/dotnet/runtime) from 6.0.0 to 7.0.0. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v7.0.0) --- updated-dependencies: - dependency-name: System.Collections.Immutable dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Statiq.Markdown](https://github.com/statiqdev/Statiq.Framework) from 1.0.0-beta.62 to 1.0.0-beta.65. - [Release notes](https://github.com/statiqdev/Statiq.Framework/releases) - [Changelog](https://github.com/statiqdev/Statiq.Framework/blob/main/RELEASE.md) - [Commits](statiqdev/Statiq.Framework@v1.0.0-beta.62...v1.0.0-beta.65) --- updated-dependencies: - dependency-name: Statiq.Markdown dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump libClangSharp from 14.0.0-beta1 to 15.0.0 Bumps [libClangSharp](https://github.com/dotnet/clangsharp) from 14.0.0-beta1 to 15.0.0. - [Release notes](https://github.com/dotnet/clangsharp/releases) - [Commits](dotnet/ClangSharp@v14.0.0-beta1...v15.0.0) --- updated-dependencies: - dependency-name: libClangSharp dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update Directory.Packages.props Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>
Bumps [Statiq.Razor](https://github.com/statiqdev/Statiq.Framework) from 1.0.0-beta.48 to 1.0.0-beta.66. - [Release notes](https://github.com/statiqdev/Statiq.Framework/releases) - [Changelog](https://github.com/statiqdev/Statiq.Framework/blob/main/RELEASE.md) - [Commits](statiqdev/Statiq.Framework@v1.0.0-beta.48...v1.0.0-beta.66) --- updated-dependencies: - dependency-name: Statiq.Razor dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1257) Bumps [Microsoft.CodeAnalysis.PublicApiAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.3.1 to 3.3.4. - [Release notes](https://github.com/dotnet/roslyn-analyzers/releases) - [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/main/PostReleaseActivities.md) - [Commits](dotnet/roslyn-analyzers@v3.3.1...v3.3.4) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.PublicApiAnalyzers dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Moq](https://github.com/moq/moq4) from 4.17.2 to 4.18.4. - [Release notes](https://github.com/moq/moq4/releases) - [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md) - [Commits](devlooped/moq@v4.17.2...v4.18.4) --- updated-dependencies: - dependency-name: Moq dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Statiq.Feeds](https://github.com/statiqdev/Statiq.Framework) from 1.0.0-beta.65 to 1.0.0-beta.66. - [Release notes](https://github.com/statiqdev/Statiq.Framework/releases) - [Changelog](https://github.com/statiqdev/Statiq.Framework/blob/main/RELEASE.md) - [Commits](statiqdev/Statiq.Framework@v1.0.0-beta.65...v1.0.0-beta.66) --- updated-dependencies: - dependency-name: Statiq.Feeds dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Statiq.Yaml](https://github.com/statiqdev/Statiq.Framework) from 1.0.0-beta.62 to 1.0.0-beta.66. - [Release notes](https://github.com/statiqdev/Statiq.Framework/releases) - [Changelog](https://github.com/statiqdev/Statiq.Framework/blob/main/RELEASE.md) - [Commits](statiqdev/Statiq.Framework@v1.0.0-beta.62...v1.0.0-beta.66) --- updated-dependencies: - dependency-name: Statiq.Yaml dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>
Bumps [Microsoft.Build.Locator](https://github.com/microsoft/MSBuildLocator) from 1.4.1 to 1.5.5. - [Release notes](https://github.com/microsoft/MSBuildLocator/releases) - [Commits](https://github.com/microsoft/MSBuildLocator/commits) --- updated-dependencies: - dependency-name: Microsoft.Build.Locator dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Statiq.App](https://github.com/statiqdev/Statiq.Framework) from 1.0.0-beta.65 to 1.0.0-beta.66. - [Release notes](https://github.com/statiqdev/Statiq.Framework/releases) - [Changelog](https://github.com/statiqdev/Statiq.Framework/blob/main/RELEASE.md) - [Commits](statiqdev/Statiq.Framework@v1.0.0-beta.65...v1.0.0-beta.66) --- updated-dependencies: - dependency-name: Statiq.App dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Microsoft.Extensions.Hosting](https://github.com/dotnet/runtime) from 6.0.1 to 7.0.0. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.1...v7.0.0) --- updated-dependencies: - dependency-name: Microsoft.Extensions.Hosting dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [HtmlAgilityPack](https://github.com/zzzprojects/html-agility-pack) from 1.11.43 to 1.11.46. - [Release notes](https://github.com/zzzprojects/html-agility-pack/releases) - [Commits](zzzprojects/html-agility-pack@v1.11.43...v1.11.46) --- updated-dependencies: - dependency-name: HtmlAgilityPack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ClangSharp.PInvokeGenerator](https://github.com/dotnet/clangsharp) from 15.0.0 to 15.0.2. - [Release notes](https://github.com/dotnet/clangsharp/releases) - [Commits](dotnet/ClangSharp@v15.0.0...v15.0.2) --- updated-dependencies: - dependency-name: ClangSharp.PInvokeGenerator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 17.9.0 to 19.9.2. - [Release notes](https://github.com/VerifyTests/Verify/releases) - [Commits](https://github.com/VerifyTests/Verify/commits) --- updated-dependencies: - dependency-name: Verify.Xunit dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
HurricanKai
requested review from
ThomasMiz,
Beyley and
a team
as code owners
February 12, 2023 06:12
auto-merge was automatically disabled
February 12, 2023 06:12
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
A short summary of this PR and what it adds/removes/fixes.
Related issues, Discord discussions, or proposals
Links go here.
Further Comments