Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert default value of UseMinimumLoginTimeout context switch to 'true' #2419

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Revert default value of UseMinimumLoginTimeout context switch to 'true' #2419

merged 3 commits into from
Nov 25, 2024

Conversation

EamonHetherton
Copy link
Contributor

@EamonHetherton EamonHetherton commented Mar 19, 2024 •
edited by cheenamalhotra
Loading

Fixes #2415

@EamonHetherton EamonHetherton changed the title Fix 2415 Revert default value of UseMinimumLoginTimeout context switch to 'true' Mar 19, 2024
@cheenamalhotra
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cheenamalhotra cheenamalhotra linked an issue Nov 23, 2024 that may be closed by this pull request
default value for context switch "Switch.Microsoft.Data.SqlClient.UseOneSecFloorInTimeoutCalculationDuringLogin" has changed from 'true' to 'false' #2415
Closed
@cheenamalhotra cheenamalhotra added this to the 6.0-preview3 milestone Nov 23, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.68%. Comparing base (9056f13) to head (04dce94).
Report is 251 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2419      +/-   ##
==========================================
+ Coverage   66.85%   72.68%   +5.83%     
==========================================
  Files         304      285      -19     
  Lines       61576    59160    -2416     
==========================================
+ Hits        41168    43002    +1834     
+ Misses      20408    16158    -4250
Flag Coverage Δ
addons 92.58% <ø> (∅)
netcore 75.45% <ø> (+4.37%) ⬆️
netfx 71.09% <ø> (+6.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdaigle mdaigle merged commit 3fe496c into dotnet:main Nov 25, 2024
82 checks passed
@mdaigle mdaigle added the 🐛 Bug! Issues that are bugs in the drivers we maintain. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@mdaigle mdaigle mdaigle approved these changes

@benrr101 benrr101 Awaiting requested review from benrr101

@apoorvdeshmukh apoorvdeshmukh Awaiting requested review from apoorvdeshmukh

@David-Engel David-Engel Awaiting requested review from David-Engel

@samsharma2700 samsharma2700 Awaiting requested review from samsharma2700

Assignees
No one assigned
Labels
🐛 Bug! Issues that are bugs in the drivers we maintain.
Projects
None yet
Milestone
6.0-preview3
3 participants
@EamonHetherton @cheenamalhotra @mdaigle