Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default value of UseMinimumLoginTimeout context switch to 'true' #2419

Merged
merged 3 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,10 @@ public static bool UseMinimumLoginTimeout
{
if (s_useMinimumLoginTimeout == Tristate.NotInitialized)
{
if (AppContext.TryGetSwitch(UseMinimumLoginTimeoutString, out bool returnedValue) && returnedValue)
if (!AppContext.TryGetSwitch(UseMinimumLoginTimeoutString, out bool returnedValue) || returnedValue)
{
s_useMinimumLoginTimeout = Tristate.True;
}
}
cheenamalhotra marked this conversation as resolved.
Show resolved Hide resolved
else
{
s_useMinimumLoginTimeout = Tristate.False;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Reflection;
using Xunit;

namespace Microsoft.Data.SqlClient.Tests
{
public class LocalAppContextSwitchesTests
{
[Theory]
[InlineData("SuppressInsecureTLSWarning", false)]
[InlineData("LegacyRowVersionNullBehavior", false)]
[InlineData("MakeReadAsyncBlocking", false)]
[InlineData("UseMinimumLoginTimeout", true)]
public void DefaultSwitchValue(string property, bool expectedDefaultValue)
{
var switchesType = typeof(SqlCommand).Assembly.GetType("Microsoft.Data.SqlClient.LocalAppContextSwitches");

var switchValue = (bool)switchesType.GetProperty(property, BindingFlags.Public | BindingFlags.Static).GetValue(null);

Assert.Equal(expectedDefaultValue, switchValue);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
<Compile Include="SqlAuthenticationProviderTest.cs" />
<Compile Include="SqlClientLoggerTest.cs" />
<Compile Include="SqlCommandSetTest.cs" />
<Compile Include="LocalAppContextSwitchesTests.cs" />
<Compile Include="SqlConfigurableRetryLogicTest.cs" />
<Compile Include="SqlCommandBuilderTest.cs" />
<Compile Include="SqlBulkCopyTest.cs" />
Expand Down
Loading