[Xamarin.ProjectTools] Handle xbuilds negative index error. #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an occasional issue with xbuild throwing an error. Unhandled Exception: System.ArgumentException: is negative Parameter name: count at (wrapper managed-to-native) System.Buffer.InternalBlockCopy(System.Array,int,System.Array,int,int) at System.IO.StreamWriter.Write (System.Char[] buffer, System.Int32 index, System.Int32 count) [0x00094] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/referencesource/mscorlib/system/io/streamwriter.cs:415 at System.IO.TextWriter.WriteLine (System.String value) [0x00070] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/referencesource/mscorlib/system/io/textwriter.cs:490 at Microsoft.Build.BuildEngine.ConsoleLogger+BuildRecord.WriteLine (System.String message) [0x00051] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/ConsoleLogger.cs:856 at Microsoft.Build.BuildEngine.ConsoleLogger+BuildRecord.DumpPerformanceSummary () [0x0000c] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/ConsoleLogger.cs:903 at Microsoft.Build.BuildEngine.ConsoleLogger+BuildRecord.BuildFinishedHandlerActual (Microsoft.Build.Framework.BuildFinishedEventArgs args) [0x0003e] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/ConsoleLogger.cs:572 at Microsoft.Build.BuildEngine.ConsoleLogger+BuildRecord.BuildFinishedHandler (Microsoft.Build.Framework.BuildFinishedEventArgs args) [0x00000] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/ConsoleLogger.cs:558 at Microsoft.Build.BuildEngine.ConsoleLogger.BuildFinishedHandler (System.Object sender, Microsoft.Build.Framework.BuildFinishedEventArgs e) [0x00000] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/ConsoleLogger.cs:306 at (wrapper delegate-invoke) <Module>.invoke_void_object_BuildFinishedEventArgs(object,Microsoft.Build.Framework.BuildFinishedEventArgs) at Microsoft.Build.BuildEngine.EventSource.FireBuildFinished (System.Object sender, Microsoft.Build.Framework.BuildFinishedEventArgs bfea) [0x00008] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/EventSource.cs:103 at Microsoft.Build.BuildEngine.Engine.LogBuildFinished (System.Boolean succeeded) [0x0000d] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/Engine.cs:485 at Microsoft.Build.BuildEngine.Engine.UnregisterAllLoggers () [0x00008] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/Engine.cs:391 at Mono.XBuild.CommandLine.MainClass.Execute () [0x00390] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/tools/xbuild/Main.cs:170 at Mono.XBuild.CommandLine.MainClass.Main (System.String[] args) [0x0000c] in /Users/builder/data/lanes/5533/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/tools/xbuild/Main.cs:62 [ERROR] FATAL UNHANDLED EXCEPTION: System.ArgumentException: is negative So we should handle this like we do the native crash. If we detect it we should re-run the build. Hopefully that will make our tests a bit more stable.
jonathanpeppers
approved these changes
Dec 7, 2017
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 18, 2020
Changes: xamarin/monodroid@8466972...16cb1cb * xamarin/monodroid@16cb1cb1a: Bump to xamarin/androidtools@068e4f5 (dotnet#1084) * xamarin/monodroid@8f61f0cae: Bump to xamarin/android-sdk-installer@d9276b4 (dotnet#1085) * xamarin/monodroid@bec720cd0: Bump to xamarin/jar2xml@4125da65 (dotnet#1083) * xamarin/monodroid@a49e901d6: [tools/msbuild] update <BuildApk/> task inputs (dotnet#1082) * xamarin/monodroid@b9f16c002: Bump to xamarin/androidtools@5412dc8 (dotnet#1081) * xamarin/monodroid@673a74961: [.NET 5] fix for ALC isolation between assemblies (dotnet#1080)
jonpryor
added a commit
that referenced
this pull request
Apr 19, 2020
Changes: xamarin/monodroid@8466972...16cb1cb * xamarin/monodroid@16cb1cb1a: Bump to xamarin/androidtools@068e4f5 (#1084) * xamarin/monodroid@8f61f0cae: Bump to xamarin/android-sdk-installer@d9276b4 (#1085) * xamarin/monodroid@bec720cd0: Bump to xamarin/jar2xml@4125da65 (#1083) * xamarin/monodroid@a49e901d6: [tools/msbuild] update <BuildApk/> task inputs (#1082) * xamarin/monodroid@b9f16c002: Bump to xamarin/androidtools@5412dc8 (#1081) * xamarin/monodroid@673a74961: [.NET 5] fix for ALC isolation between assemblies (#1080)
jonpryor
added a commit
that referenced
this pull request
Apr 23, 2020
Changes: xamarin/monodroid@70a1164...d35c422 * xamarin/monodroid@d35c4221b: Bump to xamarin/jar2xml@4125da65 (#1083) * xamarin/monodroid@ea68087b0: [tools/msbuild] update <BuildApk/> task inputs (#1082) * xamarin/monodroid@16c2eb29e: Bump to xamarin/androidtools@fba677c4 (#1081) * xamarin/monodroid@53abd4f03: [.NET 5] fix for ALC isolation between assemblies (#1080)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an occasional issue with xbuild throwing an error.
So we should handle this like we do the native crash. If we
detect it we should re-run the build. Hopefully that will
make our tests a bit more stable.