Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.ProjectTools] Handle xbuilds negative index error. #1082

Merged
merged 1 commit into from
Dec 7, 2017
+7 −0
Merged

[Xamarin.ProjectTools] Handle xbuilds negative index error. #1082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Common/Builder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ namespace Xamarin.ProjectTools
public class Builder : IDisposable
{
const string SigSegvError = "Got a SIGSEGV while executing native code";
const string ConsoleLoggerError = "[ERROR] FATAL UNHANDLED EXCEPTION: System.ArgumentException: is negative";
string buildLogFullPath;
public bool IsUnix { get; set; }
public bool RunningMSBuild { get; set; }
Expand Down Expand Up @@ -316,6 +317,9 @@ protected bool BuildInternal (string projectOrSolution, string target, string []
if (e.Data.StartsWith (SigSegvError, StringComparison.OrdinalIgnoreCase)) {
nativeCrashDetected = true;
}
if (e.Data.StartsWith (ConsoleLoggerError, StringComparison.OrdinalIgnoreCase)) {
nativeCrashDetected = true;
}
}
if (e.Data == null)
err.Set ();
Expand All @@ -326,6 +330,9 @@ protected bool BuildInternal (string projectOrSolution, string target, string []
if (e.Data.StartsWith (SigSegvError, StringComparison.OrdinalIgnoreCase)) {
nativeCrashDetected = true;
}
if (e.Data.StartsWith (ConsoleLoggerError, StringComparison.OrdinalIgnoreCase)) {
nativeCrashDetected = true;
}
}
if (e.Data == null)
stdout.Set ();
Expand Down