bump Android platform-tools to fix adb server version mismatch with P. #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you are running Android O or above as the Android target to test `run-apk-tests`, it will fail because of adb server version mismatch (39 vs. 40). It is a typical adb issue e.g.: https://sqa.stackexchange.com/questions/20524/how-to-resolve-adb-server-version-32-doesnt-match-this-client-36-killin We need newer adb to fix this issue.
jonpryor
pushed a commit
that referenced
this pull request
Jul 20, 2018
Context: mono/mono#9473 (comment) Context: #1858 Before [mono/mono:master@52dccf8c][m52dc] ([mono:2018-02@077307fc][m0773]), mono would hardcode the `platform-tools` version to be installed, meaning if xamarin-android *wanted* to install a newer `platform-tools` version (#1858), *we couldn't*, because mono controlled that. Altering the `platform-tools` version would require altering and bumping mono. In [mono/mono:master@52dccf8c][m52dc], mono now allows xamarin-android to explicitly specify the `platform-tools` version to install, by overriding the `$(ANDROID_PLATFORM_TOOLS_VERSION)` make variable. Introduce a new `$(XAPlatformToolsVersion)` MSBuild property to control mono's `$(ANDROID_PLATFORM_TOOLS_VERSION)` value, allowing xamarin-android to control and update this value in the future. [m52dc]: mono/mono@52dccf8 [m0773]: mono/mono@077307f
jonpryor
pushed a commit
that referenced
this pull request
Aug 3, 2018
Context: mono/mono#9473 (comment) Context: #1858 Before [mono/mono:master@52dccf8c][m52dc] ([mono:2018-02@077307fc][m0773]), mono would hardcode the `platform-tools` version to be installed, meaning if xamarin-android *wanted* to install a newer `platform-tools` version (#1858), *we couldn't*, because mono controlled that. Altering the `platform-tools` version would require altering and bumping mono. In [mono/mono:master@52dccf8c][m52dc], mono now allows xamarin-android to explicitly specify the `platform-tools` version to install, by overriding the `$(ANDROID_PLATFORM_TOOLS_VERSION)` make variable. Introduce a new `$(XAPlatformToolsVersion)` MSBuild property to control mono's `$(ANDROID_PLATFORM_TOOLS_VERSION)` value, allowing xamarin-android to control and update this value in the future. [m52dc]: mono/mono@52dccf8 [m0773]: mono/mono@077307f
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 11, 2018
If you are running Android O or above as the Android target to test `make run-apk-tests`, it will fail because of an `adb` server version mismatch (39 vs. 40). This is a common `adb` issue e.g.: https://sqa.stackexchange.com/questions/20524/how-to-resolve-adb-server-version-32-doesnt-match-this-client-36-killin Bump to Android platform-tools r28 so that we have an updated `adb`, which will avoid the version mismatch error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are running Android O or above as the Android target to test
run-apk-tests, it will fail because of adb server version mismatch(39 vs. 40). It is a typical adb issue e.g.:
https://sqa.stackexchange.com/questions/20524/how-to-resolve-adb-server-version-32-doesnt-match-this-client-36-killin
We need newer adb to fix this issue.