Make platform-tools setup customizible and tell it to mono/sdks setup. #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsushieno
force-pushed
the
customizible-platform-tools
branch
from
1535905 to
d46970a
Compare
jonpryor
reviewed
Jul 19, 2018
| @@ -84,6 +84,7 @@ | |||
| <AllSupportedTargetAndroidAbis>$(AllSupported32BitTargetAndroidAbis);$(AllSupported64BitTargetAndroidAbis)</AllSupportedTargetAndroidAbis> | |||
| <XABuildToolsVersion>28</XABuildToolsVersion> | |||
| <XABuildToolsFolder Condition="'$(XABuildToolsFolder)' == ''">28.0.0</XABuildToolsFolder> | |||
| <XAPlatformToolsVersion>28.0.0</XAPlatformToolsVersion> | |||
There was a problem hiding this comment.
Should this be Conditional/overridable, as $(XABuildToolsFolder) is?
There was a problem hiding this comment.
That's true. Though there are other properties without Condition, they are added in some need perhaps? We'll do so too.
|
This PR should also include a bump to external/mono, otherwise this change won't actually control anything. Or we do the mono bump as a separate PR... |
|
Separate mono bump PR: #1981 |
jonpryor
pushed a commit
that referenced
this pull request
Aug 3, 2018
Context: mono/mono#9473 (comment) Context: #1858 Before [mono/mono:master@52dccf8c][m52dc] ([mono:2018-02@077307fc][m0773]), mono would hardcode the `platform-tools` version to be installed, meaning if xamarin-android *wanted* to install a newer `platform-tools` version (#1858), *we couldn't*, because mono controlled that. Altering the `platform-tools` version would require altering and bumping mono. In [mono/mono:master@52dccf8c][m52dc], mono now allows xamarin-android to explicitly specify the `platform-tools` version to install, by overriding the `$(ANDROID_PLATFORM_TOOLS_VERSION)` make variable. Introduce a new `$(XAPlatformToolsVersion)` MSBuild property to control mono's `$(ANDROID_PLATFORM_TOOLS_VERSION)` value, allowing xamarin-android to control and update this value in the future. [m52dc]: mono/mono@52dccf8 [m0773]: mono/mono@077307f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: mono/mono#9473 (comment)