Disable marshal methods generation by default #9336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've learned that enabling marshal methods appears to break not only Blazor apps, but also select other apps. Since we currently have no insight into what is exactly going on (only suspicions), it is prudent that we disable marshal method generation by default for NET9 release.
grendello
requested review from
dellis1972 and
jonathanpeppers
as code owners
dellis1972
approved these changes
Sep 26, 2024
|
Draft commit message: Context: https://github.com/dotnet/android/issues/8253
We've had a number of reports about *hangs* when LLVM Marshal Methods
are enabled (see also dotnet/android#8253), but we had been willing
to accept having LLVM Marshal Methods enabled by default as it helps
improve app startup time.
However, [a customer reported a native crash][0] when LLVM Marshal
Methods are enabled:
> ![Thread Stack Trace][1]
syscall at line 28 within libc
__futex_wait_ex(void volatile*, bool, int, bool, timespec const*) at line 144 within libc
sem_wait at line 108 within libc
within libmonosgen-2.0.so (Build Id: …)
within <anonymous:…>
This native crash suggests "something going wrong" within MonoVM.
We find this "scary" enough that we feel it is once again prudent
to disable LLVM Marshal Methods by default in .NET 9.
[0]: https://discord.com/channels/732297728826277939/732297837953679412/1288758900627345463
[1]: https://cdn.discordapp.com/attachments/732297837953679412/1288758900522483712/05F6ED48-2BBA-4FC0-A54F-81BB57606500.png?ex=66f659c1&is=66f50841&hm=8f6f78f283f8c03e9fb37a452ad5d0babaaad3dd4bcc1b4887f4dcf60f651c12& |
jonathanpeppers
approved these changes
Sep 26, 2024
jonathanpeppers
pushed a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Sep 30, 2024
Context: dotnet#8253 Context: dotnet#9343 We've had a number of reports about *hangs* when LLVM Marshal Methods are enabled (see also dotnet#8253), but we had been willing to accept having LLVM Marshal Methods enabled by default as it helps improve app startup time. However, [a customer reported a native crash][0] when LLVM Marshal Methods are enabled: > ![Thread Stack Trace][1] syscall at line 28 within libc __futex_wait_ex(void volatile*, bool, int, bool, timespec const*) at line 144 within libc sem_wait at line 108 within libc within libmonosgen-2.0.so (Build Id: …) within <anonymous:…> This native crash suggests "something going wrong" within MonoVM. We find this "scary" enough that we feel it is once again prudent to disable LLVM Marshal Methods by default in .NET 9, by setting the default value of `$(AndroidEnableMarshalMethods)`=False. Even though dotnet#9343 has a potential fix for the hang, we feel that we're too close to .NET 9 GA to validate in the wild. This feature will need to wait for .NET 10. 🙁 To explicitly enable LLVM Marshal Methods, set `$(AndroidEnableMarshalMethods)`=True in your App `.csproj`. [0]: https://discord.com/channels/732297728826277939/732297837953679412/1288758900627345463 [1]: https://cdn.discordapp.com/attachments/732297837953679412/1288758900522483712/05F6ED48-2BBA-4FC0-A54F-81BB57606500.png?ex=66f659c1&is=66f50841&hm=8f6f78f283f8c03e9fb37a452ad5d0babaaad3dd4bcc1b4887f4dcf60f651c12&
jonathanpeppers
added a commit
that referenced
this pull request
Sep 30, 2024
…9346) Context: #8253 Context: #9343 We've had a number of reports about *hangs* when LLVM Marshal Methods are enabled (see also #8253), but we had been willing to accept having LLVM Marshal Methods enabled by default as it helps improve app startup time. However, [a customer reported a native crash][0] when LLVM Marshal Methods are enabled: > ![Thread Stack Trace][1] syscall at line 28 within libc __futex_wait_ex(void volatile*, bool, int, bool, timespec const*) at line 144 within libc sem_wait at line 108 within libc within libmonosgen-2.0.so (Build Id: …) within <anonymous:…> This native crash suggests "something going wrong" within MonoVM. We find this "scary" enough that we feel it is once again prudent to disable LLVM Marshal Methods by default in .NET 9, by setting the default value of `$(AndroidEnableMarshalMethods)`=False. Even though #9343 has a potential fix for the hang, we feel that we're too close to .NET 9 GA to validate in the wild. This feature will need to wait for .NET 10. 🙁 To explicitly enable LLVM Marshal Methods, set `$(AndroidEnableMarshalMethods)`=True in your App `.csproj`. [0]: https://discord.com/channels/732297728826277939/732297837953679412/1288758900627345463 [1]: https://cdn.discordapp.com/attachments/732297837953679412/1288758900522483712/05F6ED48-2BBA-4FC0-A54F-81BB57606500.png?ex=66f659c1&is=66f50841&hm=8f6f78f283f8c03e9fb37a452ad5d0babaaad3dd4bcc1b4887f4dcf60f651c12& Co-authored-by: Marek Habersack <grendel@twistedcode.net>
jonathanpeppers
added a commit
to dotnet/docs-maui
that referenced
this pull request
Oct 14, 2024
It appears this section might have been AI generated, as it appeared to contain "hallucinated" MSBuild property names. It also didn't make sense that the example set things to `false`. I updated the section as appropriate. We also have made the feature non-default in: * dotnet/android#9336 I also linked to GitHub commits, as we have more detailed text inside, generally, than pull requests.
davidbritch
pushed a commit
to dotnet/docs-maui
that referenced
this pull request
Oct 15, 2024
It appears this section might have been AI generated, as it appeared to contain "hallucinated" MSBuild property names. It also didn't make sense that the example set things to `false`. I updated the section as appropriate. We also have made the feature non-default in: * dotnet/android#9336 I also linked to GitHub commits, as we have more detailed text inside, generally, than pull requests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've learned that enabling marshal methods appears to break not only
Blazor apps, but also select other apps. Since we currently have no
insight into what is exactly going on (only suspicions), it is prudent
that we disable marshal method generation by default for NET9 release.