Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs about "LLVM Marshal Methods" #2566

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Oct 14, 2024

It appears this section might have been AI generated, as it appeared to contain "hallucinated" MSBuild property names. It also didn't make sense that the example set things to false. I updated the section as appropriate.

We also have made the feature non-default in:

I also linked to GitHub commits, as we have more detailed text inside, generally, than pull requests.


Internal previews

📄 File 🔗 Preview link
docs/whats-new/dotnet-9.md docs/whats-new/dotnet-9

It appears this section might have been AI generated, as it appeared
to contain "hallucinated" MSBuild property names. It also didn't make
sense that the example set things to `false`. I updated the section as
appropriate.

We also have made the feature non-default in:

* dotnet/android#9336

I also linked to GitHub commits, as we have more detailed text inside,
generally, than pull requests.

```xml
<PropertyGroup Condition="'$(TargetFramework)' == 'net9.0-android'">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to put Condition in the example as $(AndroidEnableMarshalMethods) will have no affect on other platforms.

@davidbritch
Copy link
Contributor

@jonathanpeppers It wasn't AI generated (AI generated content requires a legal disclaimer) - it was PM generated (see https://github.com/dotnet/core/blob/main/release-notes/9.0/preview/preview5/dotnetmaui.md#llvm-marshalled-methods).

Copy link
Contributor

@davidbritch davidbritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidbritch davidbritch merged commit d3e8fce into main Oct 15, 2024
4 checks passed
@davidbritch davidbritch deleted the dev/peppers/marshalmethods branch October 15, 2024 08:22
@jonathanpeppers
Copy link
Member Author

@jonathanpeppers It wasn't AI generated (AI generated content requires a legal disclaimer) - it was PM generated (see https://github.com/dotnet/core/blob/main/release-notes/9.0/preview/preview5/dotnetmaui.md#llvm-marshalled-methods).

It's weird, the "made up" property names aren't in our repo at all:

The simplest explanation (maybe?) is someone took all the release notes and fed them through an LLM, which would happily invent plausible MSBuild property names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants