Skip to content

Commit

Permalink
[main] Bump us to Octokit v10.0.0
Browse files Browse the repository at this point in the history
- see dotnet/dnceng#2065
- comment about Octokit.dll not being signed is no longer true (since v4.0.0)
  - still need to avoid signing Microsoft.DotNet.Maestro.Tasks.dll for other reasons
  • Loading branch information
dougbu committed Feb 23, 2024
1 parent edda345 commit f3ee316
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
<PackageVersion Include="NuGet.Protocol" Version="6.7.1" />
<PackageVersion Include="NUnit" Version="4.0.1" />
<PackageVersion Include="NUnit3TestAdapter" Version="4.5.0" />
<PackageVersion Include="Octokit" Version="0.49.0" />
<PackageVersion Include="Octokit" Version="10.0.0" />
<PackageVersion Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.7.0" />
<PackageVersion Include="OpenTelemetry.Extensions.Hosting" Version="1.7.0" />
<PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.7.0" />
Expand All @@ -138,4 +138,4 @@
<PackageVersion Include="Verify.NUnit" Version="19.6" />
<PackageVersion Include="YamlDotNet" Version="13.7.1" />
</ItemGroup>
</Project>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<Description>This package include tasks involving Maestro++ and the Build Asset Registry.</Description>
<DevelopmentDependency>true</DevelopmentDependency>
<PackageType>MSBuildSdk</PackageType>
<!-- Octokit is not strong named yet (https://github.com/octokit/octokit.net/blob/master/docs/strong-naming.md) -->
<SignAssembly>false</SignAssembly>
<!-- Build Tasks should not include any dependencies -->
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
Expand Down

0 comments on commit f3ee316

Please sign in to comment.