Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump us to Octokit v10.0.0 to avoid int32 issues problem #2065

Closed
3 tasks
AlitzelMendez opened this issue Feb 22, 2024 · 6 comments
Closed
3 tasks

Bump us to Octokit v10.0.0 to avoid int32 issues problem #2065

AlitzelMendez opened this issue Feb 22, 2024 · 6 comments
Assignees

Comments

@AlitzelMendez
Copy link
Member

AlitzelMendez commented Feb 22, 2024

This is a problem occurring on Octokit library in which is unable to grab new issues as the id is larger than int32.

Consequences:

  • Build analysis cannot read new issues and if it tries the entire process of the build fails

Impacted issues:

  • All issues opened on 02/21 and beyond

Mitigation:

  • Remove those issues for known issues until this is fixed to avoid blocking build analysis

Release Note Category

  • Feature changes/additions
  • Bug fixes
  • Internal Infrastructure Improvements

Release Note Description

Bump us to Octokit v10.0.0

@AlitzelMendez
Copy link
Member Author

Octokit issue: octokit/octokit.net#2889

dougbu added a commit to dougbu/arcade that referenced this issue Feb 23, 2024
dougbu added a commit to dougbu/arcade that referenced this issue Feb 23, 2024
dougbu added a commit to dougbu/arcade that referenced this issue Feb 23, 2024
dougbu added a commit to dougbu/arcade that referenced this issue Feb 23, 2024
dougbu added a commit to dougbu/arcade-services that referenced this issue Feb 23, 2024
- see dotnet/dnceng#2065
- assembly is now (since v4.0.0) strong named
@AlitzelMendez AlitzelMendez changed the title [Build Analysis] Unable to process new known issues as id is larger than int32 Bump us to Octokit v10.0.0 to avoid int32 issues problem Feb 23, 2024
dougbu added a commit to dotnet/arcade that referenced this issue Feb 23, 2024
dougbu added a commit to dotnet/arcade that referenced this issue Feb 23, 2024
dougbu added a commit to dotnet/arcade-services that referenced this issue Feb 23, 2024
- see dotnet/dnceng#2065
- assembly is now (since v4.0.0) strong named
dougbu added a commit to dotnet/arcade that referenced this issue Feb 23, 2024
dougbu added a commit to dotnet/arcade-services that referenced this issue Feb 23, 2024
- see dotnet/dnceng#2065
- comment about Octokit.dll not being signed is no longer true (since v4.0.0)
  - still need to avoid signing Microsoft.DotNet.Maestro.Tasks.dll for other reasons
dougbu added a commit to dotnet/arcade-services that referenced this issue Feb 23, 2024
### Update dependencies from https://github.com/dotnet/dnceng-shared build 20240222.2

CoreHealthMonitor , Microsoft.AspNetCore.ApiPagination , Microsoft.AspNetCore.ApiVersioning , Microsoft.AspNetCore.ApiVersioning.Analyzers , Microsoft.AspNetCore.ApiVersioning.Swashbuckle , Microsoft.DncEng.CommandLineLib , Microsoft.DncEng.Configuration.Extensions , Microsoft.DotNet.Authentication.Algorithms , Microsoft.DotNet.GitHub.Authentication , Microsoft.DotNet.Internal.DependencyInjection , Microsoft.DotNet.Internal.DependencyInjection.Testing , Microsoft.DotNet.Internal.Health , Microsoft.DotNet.Internal.Logging , Microsoft.DotNet.Internal.Testing.DependencyInjection.Abstractions , Microsoft.DotNet.Internal.Testing.DependencyInjectionCodeGen , Microsoft.DotNet.Internal.Testing.Utility , Microsoft.DotNet.Kusto , Microsoft.DotNet.Metrics , Microsoft.DotNet.ServiceFabric.ServiceHost , Microsoft.DotNet.Services.Utility , Microsoft.DotNet.Web.Authentication , ServiceFabricMocks
 From Version 1.1.0-beta.24115.1 -> To Version 1.1.0-beta.24122.2

### [main] Bump us to Octokit v10.0.0
- see dotnet/dnceng#2065
- comment about Octokit.dll not being signed is no longer true (since v4.0.0)
  - still need to avoid signing Microsoft.DotNet.Maestro.Tasks.dll for other reasons

### Credits

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
premun added a commit to premun/arcade-services that referenced this issue Feb 23, 2024
This is a special rollout to address dotnet/dnceng#2065
@AlitzelMendez
Copy link
Member Author

AlitzelMendez commented Feb 24, 2024

dougbu added a commit to dotnet/arcade that referenced this issue Mar 1, 2024
@dougbu dougbu self-assigned this Mar 1, 2024
@dougbu
Copy link
Member

dougbu commented Mar 1, 2024

@AlitzelMendez I think we're done here except for the latest 7.0 build rolling out to customers. should this be Waiting for Rollout or perhaps Validate instead of Tracking (blocked)

@AlitzelMendez
Copy link
Member Author

yes, makes sense, I will move to waiting for rollout :)

@AlitzelMendez
Copy link
Member Author

everything has been merged and rolled out, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants