add terminfo-db to FreeBSD package requirements #7588

Thefrank · 2021-07-04T21:20:56Z

runtime can use terminfo under FreeBSD but only with this additional package
from feedback: Add FreeBSD terminfo location runtime#55152 (comment)

* runtime can use terminfo under FreeBSD but only with this additional package * from feedback: dotnet/runtime#55152 (comment)

am11 · 2021-07-04T21:37:30Z

Thank you! 😎

Yes we can rev the FreeBSD OS version in arcade which are EOL. For the next major version, we would need to clone this directory https://github.com/dotnet/dotnet-buildtools-prereqs-docker/tree/main/src/ubuntu/18.04/cross/freebsd/12 (note some files in that dir are symlinks).

To pick up these changes in runtime CI, we would need to wait for the next tag in https://github.com/dotnet/versions/blob/main/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json, then update these files: https://github.com/dotnet/runtime/search?q=ubuntu+cross+freebsd+extension%3Ayml with that latest tag.

(few moving parts, but it usually doesn't take long to update the whole flow)

Thefrank · 2021-07-11T23:02:25Z

Debating if I should close this request and open a new PR that would cover updates to https://github.com/dotnet/arcade/blob/main/eng/common/cross/build-rootfs.sh alongside the terminfo-db addition.

Are PR renames OK here? If yes, then I can add a few more FreeBSD changes to this PR and rename it to more broadly cover the changes.

FreeBSD11 really should get removed sooner rather than later and FreeBSD 12.1 should get bumped to 12.2

am11 · 2021-07-12T00:18:08Z

You can modify the PR as you want.
I think keeping old versions in build-rootfs.sh is not as important than updating its consumer https://github.com/dotnet/dotnet-buildtools-prereqs-docker.

cc @janvorli, @wfurt, for thoughts on deprecating EOL versions of FreeBSD.

wfurt · 2021-07-12T00:31:04Z

Yes, I think we can drop 11. The docker is mostly only used only to guard agains build regressions.
What ever we do we should make sure the images can still build as I think we reference the script from
https://github.com/dotnet/dotnet-buildtools-prereqs-docker/tree/main/src/ubuntu/18.04/cross/freebsd

via https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/ubuntu/build-scripts/build-rootfs.sh

lttng-ust removable depends on dotnet/runtime#56435 merge

Thefrank · 2021-07-29T06:08:54Z

back to draft while I work on FreeBSD 13 addition and ABI support
also lttng-ust removal requires merge of dotnet/runtime#56435 so this PR should not be merged until that happens anyways

edit: I also wanted to bump the pkg version to 1.16.0 but the one listed 1.12.0 is the newest that builds without errors under the current setup

edit2: was too hasty on removing lttng-ust. Thankfully, it is only lttng-ust and not lttng-tools as that has been removed from FreeBSD 13+ (broken)

from runtime:

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
  Please set them or make sure they are set and tested correctly in the CMake files:
  LTTNG
      linked by target "coreclrtraceptprovider" in directory runtime/src/coreclr/pal/src/eventprovider/lttngprovider

am11 · 2021-07-29T07:10:17Z

Great, afaict, LTTng team seem pretty open to wide range of platform support. FreeBSD and other BSD-based OSes are supported per userspace-rcu's README https://github.com/urcu/userspace-rcu (which is the only special prerequisite of https://github.com/lttng/lttng-ust).

wfurt

LGTM.
Let me know when you feel it is ready.

also: use -j $JOBS during build while we are here

Thefrank · 2021-07-30T01:18:09Z

Long version of a very short commit:

I added support for FreeBSD 13 into the script, but from what I understand of what @am11 said, I will also need to add some files/paths/symlinks into https://github.com/dotnet/dotnet-buildtools-prereqs-docker/tree/main/src/ubuntu/18.04/cross/freebsd/ for the tools to generate a docker for FreeBSD 13. Ubuntu looks like it will have official support for public images of 18.04 until mid-2023 so it should be a pretty safe place for FreeBSD for now.

As for FreeBSD 11, it is scheduled for EOL on September 30 2021. I am leaving it here, untouched (still 11.3), as it is currently used in CI for runtime (maybe others?)
and
Moving CI to FreeBSD 12 looks like it requires waiting for the docker update to 12.2 and then modifying a few yaml files in dotnet/runtime with the updated image.

Finally, ABI support is added so that 11 uses 11, 12 uses 12, and so forth. These are added as a variable; not extracted from the release version. I could not find any discussion on why the ABI was left at 11 even for 12 :(

[Massive thanks @am11 for the pointers on how all this fits together! 😎 ]

Nonblocking but annoying: version of pkg (1.12) is the newest that will build under the current system. Current is 1.16.3. This is not an issue as 11.3, 12.2, and 13.0 all are able to use it to download the packages they need on amd64. This is also pulled from GH and not the FreeBSD repo so there is less risk of it being removed due to age/EOL.

wfurt · 2021-07-30T04:06:49Z

eng/common/cross/build-rootfs.sh

 __FreeBSDPackages="libunwind"
 __FreeBSDPackages+=" icu"
 __FreeBSDPackages+=" libinotify"
 __FreeBSDPackages+=" lttng-ust"
 __FreeBSDPackages+=" krb5"
+__FreeBSDPackages+=" terminfo-db"


Will this also work with freebsd11 ? This script is sucked in by the docker build process and I'm wondering if there is chance we break it.

If so, one option would be to first remove
https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/9458314c28f5c051299fc24f3cb602a113cfcf49/manifest.json#L553-L564

yes, terminfo-db is found in the pkg repo for FreeBSD 11, 12, and 13.

https://www.freshports.org/misc/terminfo-db/

rootwyrm · 2021-08-17T13:19:42Z

eng/common/cross/build-rootfs.sh

    echo "                              for illumos can be: illumos."
-    echo "lldbx.y - optional, LLDB version, can be: lldb3.9(default), lldb4.0, lldb5.0, lldb6.0 no-lldb. Ignored for alpine and FReeBSD"
+    echo "lldbx.y - optional, LLDB version, can be: lldb3.9(default), lldb4.0, lldb5.0, lldb6.0 no-lldb. Ignored for alpine and FreeBSD"


This is not fully true for 12-STABLE and 13-STABLE. There are known issues with base clang, so lldb from ports gets pulled in for dependencies at the absolute minimum.

rootwyrm · 2021-08-17T13:20:32Z

eng/common/cross/build-rootfs.sh

@@ -60,13 +60,15 @@ __AlpinePackages+=" krb5-dev"
 __AlpinePackages+=" openssl-dev"
 __AlpinePackages+=" zlib-dev"

-__FreeBSDBase="12.1-RELEASE"
+__FreeBSDBase="12.2-RELEASE"
 __FreeBSDPkg="1.12.0"


We need to not define __FreeBSDPkg since this is still a fast moving target, or it needs to be >=1.17.0. 1.12.0 is way behind.

rootwyrm · 2021-08-17T13:30:16Z

eng/common/cross/build-rootfs.sh

    wget -O - https://download.freebsd.org/ftp/releases/amd64/${__FreeBSDBase}/base.txz | tar -C $__RootfsDir -Jxf - ./lib ./usr/lib ./usr/libdata ./usr/include ./usr/share/keys ./etc ./bin/freebsd-version
-    # For now, ask for 11 ABI even on 12. This can be revisited later.
-    echo "ABI = \"FreeBSD:11:amd64\"; FINGERPRINTS = \"${__RootfsDir}/usr/share/keys\"; REPOS_DIR = [\"${__RootfsDir}/etc/pkg\"]; REPO_AUTOUPDATE = NO; RUN_SCRIPTS = NO;" > ${__RootfsDir}/usr/local/etc/pkg.conf
+    echo "ABI = \"FreeBSD:${__FreeBSDABI}:amd64\"; FINGERPRINTS = \"${__RootfsDir}/usr/share/keys\"; REPOS_DIR = [\"${__RootfsDir}/etc/pkg\"]; REPO_AUTOUPDATE = NO; RUN_SCRIPTS = NO;" > ${__RootfsDir}/usr/local/etc/pkg.conf


These settings are not aligned with pkgng documentation at this point. $REPO_AUTOUPDATE and $RUN_SCRIPTS are true/false. I would also recommend REPO_AUTOUPDATE = true; even with quarterly, to force security updates.

add terminfo-db to FreeBSD package requirements

099f8f8

* runtime can use terminfo under FreeBSD but only with this additional package * from feedback: dotnet/runtime#55152 (comment)

Thefrank marked this pull request as ready for review July 4, 2021 23:03

Thefrank mentioned this pull request Jul 8, 2021

Support for FreeBSD dotnet/runtime#14537

Open

Thefrank added 2 commits July 15, 2021 22:55

Merge branch 'dotnet:main' into freebsd-crossrootfs

c99d3fc

fix typo, bump FreeBSD12, remove lttng-ust from it

51c137b

lttng-ust removable depends on dotnet/runtime#56435 merge

Thefrank marked this pull request as draft July 29, 2021 06:06

lttng-ust needs to stay

71ec321

wfurt approved these changes Jul 29, 2021

View reviewed changes

add FreeBSD13, add support for FreeBSD ABI

6e8077a

also: use -j $JOBS during build while we are here

Thefrank marked this pull request as ready for review July 30, 2021 03:56

Thefrank requested a review from wfurt July 30, 2021 03:56

wfurt reviewed Jul 30, 2021

View reviewed changes

wfurt merged commit 093cd72 into dotnet:main Jul 30, 2021

Thefrank deleted the freebsd-crossrootfs branch July 31, 2021 15:53

Thefrank mentioned this pull request Aug 16, 2021

Enable the mono subset to build on FreeBSD x64 dotnet/runtime#57027

Merged

rootwyrm reviewed Aug 17, 2021

View reviewed changes

danmoseley mentioned this pull request Feb 7, 2022

Add RuntimeConfiguration.NotRelease danmoseley/arcade#1

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add terminfo-db to FreeBSD package requirements #7588

add terminfo-db to FreeBSD package requirements #7588

Thefrank commented Jul 4, 2021

am11 commented Jul 4, 2021

Thefrank commented Jul 11, 2021

am11 commented Jul 12, 2021

wfurt commented Jul 12, 2021

Thefrank commented Jul 29, 2021 •

edited

Loading

am11 commented Jul 29, 2021

wfurt left a comment

Thefrank commented Jul 30, 2021

wfurt Jul 30, 2021

Thefrank Jul 30, 2021

rootwyrm Aug 17, 2021

rootwyrm Aug 17, 2021

rootwyrm Aug 17, 2021

add terminfo-db to FreeBSD package requirements #7588

add terminfo-db to FreeBSD package requirements #7588

Conversation

Thefrank commented Jul 4, 2021

am11 commented Jul 4, 2021

Thefrank commented Jul 11, 2021

am11 commented Jul 12, 2021

wfurt commented Jul 12, 2021

Thefrank commented Jul 29, 2021 • edited Loading

am11 commented Jul 29, 2021

wfurt left a comment

Choose a reason for hiding this comment

Thefrank commented Jul 30, 2021

wfurt Jul 30, 2021

Choose a reason for hiding this comment

Thefrank Jul 30, 2021

Choose a reason for hiding this comment

rootwyrm Aug 17, 2021

Choose a reason for hiding this comment

rootwyrm Aug 17, 2021

Choose a reason for hiding this comment

rootwyrm Aug 17, 2021

Choose a reason for hiding this comment

Thefrank commented Jul 29, 2021 •

edited

Loading