-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeBSD terminfo location #55152
Conversation
`ncurses` port under FreeBSD no longer uses a hashed database but instead uses the more common "directory tree" style. This fixes like 1 failing runtime test for `System.Console`
Tagging subscribers to this area: @dotnet/area-system-console Issue Details
|
Long version: Even longer version as issue: This has been a long standing issue under FreeBSD. CC @wfurt |
Thanks Frank! I once started writing code for hasheddb build never finished it (mainly due to the lack of sufficient documentation on the initialization step, which I couldn't find).
Could you please add |
@am11 Those docker images are another thing I need to look over (e.g., EOL FreeBSD versions and use of built in LLVM) but I will add that package to any pull request I make there. |
I made an edit to the original post as I forgot to link this PR to the issue it addresses. It is the same one mentioned in my second comment under "Even longer version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add terminfo-db to FreeBSD package requirements * runtime can use terminfo under FreeBSD but only with this additional package * from feedback: dotnet/runtime#55152 (comment) * fix typo, bump FreeBSD12, remove lttng-ust from it lttng-ust removable depends on dotnet/runtime#56435 merge * lttng-ust needs to stay * add FreeBSD13, add support for FreeBSD ABI also: use -j $JOBS during build while we are here
System.Console
under FreeBSD.terminfo-db
viapkg
before building under FreeBSD.ncurses
no longer covers this.resolves: #23653