chore: Bump Testcontainers to version 3.10.0 (#5539)

updates Testcontainers to the latest version `3.10.0`. This version includes a fix for the regression/changes made in the latest MSSQL Docker image (microsoft/mssql-docker#892). The recently added workaround (#5057, #5058) is no longer necessary. Fixes #5057
dotnet · Sep 4, 2024 · 66e77d8 · 66e77d8
1 parent ab0a8d5
commit 66e77d8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -6,7 +6,7 @@
   <PropertyGroup>
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
-    <TestcontainersPackageVersion>3.9.0</TestcontainersPackageVersion>
+    <TestcontainersPackageVersion>3.10.0</TestcontainersPackageVersion>
   </PropertyGroup>
   <ItemGroup>
     <!-- AWS SDK for .NET dependencies -->

diff --git a/tests/Aspire.Microsoft.Data.SqlClient.Tests/SqlServerContainerFixture.cs b/tests/Aspire.Microsoft.Data.SqlClient.Tests/SqlServerContainerFixture.cs
@@ -3,7 +3,6 @@
 
 using Aspire.Components.Common.Tests;
 using Aspire.Hosting;
-using DotNet.Testcontainers.Builders;
 using Testcontainers.MsSql;
 using Xunit;
 
@@ -22,7 +21,6 @@ public async Task InitializeAsync()
         {
             Container = new MsSqlBuilder()
                             .WithImage($"{SqlServerContainerImageTags.Registry}/{SqlServerContainerImageTags.Image}:{SqlServerContainerImageTags.Tag}")
-                            .WithWaitStrategy(Wait.ForUnixContainer().UntilCommandIsCompleted("/opt/mssql-tools18/bin/sqlcmd", "-C", "-Q", "SELECT 1;")) // https://github.com/dotnet/aspire/issues/5057
                             .Build();
             await Container.StartAsync();
         }