Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Work around sqlserver 2022-latest latest image breaking with testcontainers #5058

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

radical
Copy link
Member

@radical radical commented Jul 24, 2024

[tests] Workaround sqlserver 2022-latest latest image failing

.. with testcontainers because the path /opt/mssql-tools/bin/sqlcmd
changed to /opt/mssql-tools18/bin/sqlcmd. But this hardcoded path is
being used in testcontainers, causing it to fail.

testcontainers/testcontainers-dotnet#1220
microsoft/mssql-docker#892

Issue: #5057

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jul 24, 2024
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from also adding the other sqlclient skip tests, this looks good to me. Thanks @radical

@radical radical added area-integrations Issues pertaining to Aspire Integrations packages testing ☑️ and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Jul 24, 2024
@radical radical enabled auto-merge (squash) July 24, 2024 19:15
@radical radical disabled auto-merge July 24, 2024 21:20
.. with testcontainers because the path `/opt/mssql-tools/bin/sqlcmd`
changed to `/opt/mssql-tools18/bin/sqlcmd`. But this hardcoded path is
being used in testcontainers, causing it to fail.

testcontainers/testcontainers-dotnet#1220
microsoft/mssql-docker#892
@radical radical changed the title Disable Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests [tests] Work around sqlserver 2022-latest latest image breaking with testcontainers Jul 24, 2024
@radical radical requested a review from joperezr July 24, 2024 21:24
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice find!

@radical radical enabled auto-merge (squash) July 24, 2024 21:49
@radical radical merged commit 2749cda into dotnet:main Jul 24, 2024
9 checks passed
@radical radical deleted the disable-efcore-sqlserver branch July 24, 2024 23:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages testing ☑️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants