Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Work around sqlserver 2022-latest latest image breaking with testcontainers #5058

Merged
merged 2 commits into from
Jul 24, 2024
Merged

[tests] Work around sqlserver 2022-latest latest image breaking with testcontainers #5058

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9288833
[tests] Workaround sqlserver 2022-latest latest image failing
radical Jul 24, 2024
afdb4b2
add comment referencing the issue
radical Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/Aspire.Microsoft.Data.SqlClient.Tests/SqlServerContainerFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using Aspire.Components.Common.Tests;
using Aspire.Hosting;
using DotNet.Testcontainers.Builders;
using Testcontainers.MsSql;
using Xunit;

Expand All @@ -21,6 +22,7 @@ public async Task InitializeAsync()
{
Container = new MsSqlBuilder()
.WithImage($"{SqlServerContainerImageTags.Registry}/{SqlServerContainerImageTags.Image}:{SqlServerContainerImageTags.Tag}")
.WithWaitStrategy(Wait.ForUnixContainer().UntilCommandIsCompleted("/opt/mssql-tools18/bin/sqlcmd", "-C", "-Q", "SELECT 1;")) // https://github.com/dotnet/aspire/issues/5057
.Build();
await Container.StartAsync();
}
Expand Down