Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure SignalR hosting readme to note ConnectionString usage and client methods to use #3390

Closed
timheuer opened this issue Apr 4, 2024 · 2 comments · Fixed by #3410
Assignees
Labels
area-integrations Issues pertaining to Aspire Integrations packages

Comments

@timheuer
Copy link
Member

timheuer commented Apr 4, 2024

The SignalR resource sets the connection string information as a ConnectionStrings__{name} But the Microsoft.Azure.SignalR client by default looks for Azure:SignalR:ConnectionString -- there is an override to supply it and the developer would have to know now to use

.AddAzureSignalR(builder.Configuration.GetConnectionString("signalr"));

Should we emit the default expected config setting instead? If not, convert this to an issue to update readme/docs on this resource to note the client consumption side

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 4, 2024
@christiannagel
Copy link

christiannagel commented Apr 4, 2024

Instead of using .AddAzureSignalR(), I was using .AddNamedAzureSignalR("signalr") which is documented to read form connectionstrings.

This is also documented here: https://learn.microsoft.com/en-us/dotnet/aspire/real-time/azure-signalr-scenario?tabs=dotnet-cli#express-the-resource

@timheuer
Copy link
Member Author

timheuer commented Apr 4, 2024

Perfect. Converting this to updating the readme to point this out

@timheuer timheuer changed the title Azure SignalR resource sets connection information as ConnectionString, but default client uses a diff default config Update Azure SignalR hosting readme to note ConnectionString usage and client methods to use Apr 4, 2024
@timheuer timheuer self-assigned this Apr 4, 2024
timheuer added a commit that referenced this issue Apr 4, 2024
@davidfowl davidfowl modified the milestones: GA, preview 6 (Apr) Apr 6, 2024
davidfowl pushed a commit that referenced this issue Apr 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants