Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure.identity.bump #3659

Closed
wants to merge 106 commits into from
Closed

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented Apr 12, 2024

Microsoft Reviewers: Open in CodeFlow

joperezr and others added 30 commits March 25, 2024 21:33
… IDE protocol version, so use the old protocol until then. (dotnet#3183)

Co-authored-by: David Fowler <davidfowl@gmail.com>
…tnet#3167)

* Retry reading kubeconfig.


---------

Co-authored-by: Mitch Denny <midenn@microsoft.com>
…ble persistent storage (dotnet#3152) (dotnet#3186)

* Use stable node name for RabbitMQ resources
* Update TestShop to use durable messages

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…use virtualization (dotnet#3178)

* Refactor console logs to render on server and use virtualization

* Fix tests

* Dashboard line record

* PR feedback

* PR feedback

* Fix console scrolling issue

---------

Co-authored-by: James Newton-King <james@newtonking.com>
…d options, support primary/secondary API keys and rotation (dotnet#3179)

* Change OTLP API key auth to use primary/secondary keys and support rotation

* Merge

* Match Kestrel HTTPS

* PR feedback

* PR feedback

---------

Co-authored-by: James Newton-King <james@newtonking.com>
* API review feedback & general cleanup including removal of currently unused features

* Align namespaces

* Hide more of the API, rename for consistency

* Hide more, rename more

* ResolutionStatus does not need to be equatable

* Make ServiceEndPointQuery public to break InternalsVisibleTo with Dns provider

* Break InternalsVisibleTo from ServiceDiscovery package to YARP by adding a middleware factory

* Remove ResolutionStatus, simplifying Service Discovery interfaces

* Clean up ServiceEndPointImpl

* Mark ServiceEndPointResolverResult as internal

* Remove unnecessary members from ServiceEndPointCollection/Source

* Seal service discovery types

* Remove IServiceEndPointSelectorFactory and use DI instead

* Remove unused endpoint selectors

* Remove unused PendingStatusRefreshPeriod option

* Rename UseServiceDiscovery to AddServiceDiscovery

* Remove possible ambiguity in AddConfigurationServiceEndPointResolver signature

* Add configuration delegate overloads to AddServiceDiscovery methods

* Clean up logging in configuration-based service endpoint provider

* API review: rename ServiceEndPointCollectionSource to IServiceEndPointBuilder

* Rename IServiceDiscoveryDelegatingHttpMessageHandlerFactory

* Rename IServiceEndPointProvider.ResolveAsync to PopulateAsync

* Hide IServiceEndPointSelector

* Remove allowedSchemes from ServiceEndPointQuery.TryParse

* Rename ServiceEndPointQuery.Host to .ServiceName

* Fix build

* Review feedback

* nit param rename

* Improve ServiceEndPointQuery.ToString output

* fixup

(cherry picked from commit 23104ee)
…ng (dotnet#3208)

Co-authored-by: Reuben Bond <reuben.bond@gmail.com>
…tation.StackExchangeRedis (dotnet#3198)

* Remove dependency from OpenTelemetry.Instrumentation.StackExchangeRedis

* Fix test builds

* Fix ActivitySourceName

* Undo IsAotCompatible change

* Update suppression comment to match OTel PR.

* Update code sync instruction for AOT

---------

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
dotnet#3190

Co-authored-by: Damian Edwards <damian@damianedwards.com>
* Allow cert warnings to bubble out.

* Fix unnecesary namespace.

---------

Co-authored-by: Mitch Denny <midenn@microsoft.com>
dotnet#3211

Co-authored-by: Damian Edwards <damian@damianedwards.com>
* initial commit for event hubs component and resource (non-functional, but skeleton is there)

* corrected roledefinition

* added consumer client (now have producer, consumer and processor components); modified davidfowl's demo EH project to use new resources and components; bugfixes;

* fixes for processor client; updated build props/targets for playground project

* Update AzureEventHubsExtensions.cs

No need to construct this (we recently changed this in the others).

* some minor refactoring of processor client; made playground project more robust

* address review items; automatically generate processor identifier from hub and consumergroup; add more comments; minor refactoring

* Update src/Aspire.Hosting.Azure/Extensions/AzureEventHubsExtensions.cs



* Update src/Aspire.Hosting.Azure/Extensions/AzureEventHubsExtensions.cs



* update EH endpoint references to use eventHubsEndpoint instead of serviceBusEndpoint; beef up processor identifier naming.

* add ability to configure credential for azure provisioner (removed my hack); added first batch of documentation for component; added partitionreceiver component.

* Update src/Components/Aspire.Azure.Messaging.EventHubs/AzureMessagingEventHubsSettings.cs



* remove azure provisioner credential configuration stuff (will go into separate PR)

* address review points; refactor namespace parsing into base eh component

* fix package tags and add new icon to shared

* remove providercredential reference from config

* fix some more errant service bus mentions and regenerate configurationschema

* fix xmlcomment on settings

* remove azure section from sample config

* update components README.md

* delete EH playground readme

* minor edits for clarification

* port ASB connection/namespace tests; rewrite validation logic to be more robust

* Update playground/AspireEventHub/EventHubs.AppHost/EventHubs.AppHost.csproj



* Update playground/AspireEventHub/EventHubsConsumer/EventHubsConsumer.csproj



* Update src/Aspire.Hosting.Azure.EventHubs/Aspire.Hosting.Azure.EventHubs.csproj



* generate aspire manifest etc for EH sample

* moved processor Start code into Execute for worker sample

* fixed another ref to service bus

* refine checkpoint blob container creation logic to avoid unnecessary permission demand if we can

* enhance logic for blob checkpoint container; add BlobContainerName to settings as an option

* persist checkpoints in processor sample for EH

* renamed settings class in tests to match AEH; was ASB.

* Fix Tracing with EventHubs
Update Telemetry and Components Progress docs
Minor cleanup feedback

* refactor EH client settings into individual classes

* Add readme for EH hosting

* Fix build

* Address PR feedback

- Remove unnecessary Directory.Packages.props entry
- Fix ConfigurationSchema.json to match implementation
- StringComparison.Ordinal is unnecessary when looking for a char

---------

Co-authored-by: Oisin Grehan <oising@gmail.com>
Co-authored-by: Mitch Denny <mitchdenny@outlook.com>
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
dotnet#3218)

* Detect conflgicting settings when using EnrichEF

* Avoid multiple blank lines

* Improve custom implementation detection

* Implement other EF providers

* Implement CosmosDb

* Update tests
dotnet#3190

Co-authored-by: Damian Edwards <damian@damianedwards.com>
… client configuration (dotnet#3231)

* Retry on YamlException when loading Kubernetes client configuration

* Add comment

---------

Co-authored-by: Reuben Bond <reuben.bond@gmail.com>
…otnet#3236)

* Fixup Azure packages after splitting

- remove unnecessary dependencies from Hosting.Azure to PostgreSQL, Redis, and SqlServer.

* Rename Aspire.Hosting.Azure.PosgresSQL to use consistent case with the rest of the libraries.

---------

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: James Newton-King <james@newtonking.com>
…et#3246)

* Support custom styles for resource style - Added support for sending custom style to the dashboard via the resource server protocol. - Use this for azure resource to show more descriptive state updates.

* Make style updates a single field in the app model - This avoid reusing old state styles by mistake when changing text - Added KnownResourceStyles

* Fixed proto comments

---------

Co-authored-by: David Fowler <davidfowl@gmail.com>
… management plugin (dotnet#3247)

* Added WithManagementPlugin() for RabbitMQ resource

Fixes dotnet#2067

Co-authored-by: Damian Edwards <damian@damianedwards.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…resource type is used. (dotnet#3258)

* Automatically AddAzureProviisioning when Azure resource type is used.

* Friendlier errors in dashboard.

* Better error message.

* Revert a change to postgres.

* Add BicepTemplate/BicepTemplateString/AzureConstruct to the test case.

* PR feedback.

* Update terminal state.

---------

Co-authored-by: Mitch Denny <midenn@microsoft.com>
Co-authored-by: Norm Johanson <normj@amazon.com>
…8.0-preview5-to-release/8.0

[automated] Merge branch 'release/8.0-preview5' => 'release/8.0'
…e/8.0-preview5

[release/8.0-preview5] Show https endpoints more consistently
* - In order for tools to better describe multiple endpoints int the manifest, we must include port information. At runtime most of the port information is dynamically generated and thus not described (for anything but containers), that doesn't work well when trying to deploy to various environments. We allocate ports in situations where there are none to match the runtime behavior. (dotnet#3274)

- Change also renames ContainerPort to TargetPort everywhere.
- Added `WithExternalHttpEndpoints` to mark all http and https endpoints as external.

* Apply suggestions from code review

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

---------

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
github-actions bot and others added 24 commits April 11, 2024 11:35
Co-authored-by: Tim Mulholland <timulhol@microsoft.com>
Co-authored-by: James Newton-King <james@newtonking.com>
…ns. (dotnet#3583)

* Hook which rewrites the container registry in annotations.

* Change to using options instead of extension method.

---------

Co-authored-by: Mitch Denny <midenn@microsoft.com>
…t#3582)

* Make CompareHelpers shared

* Resource service supports API keys

Unless unsecured, the app host will generate an API key and pass it to the dashboard via an environment variable. The dashboard then includes this key in a header for all gRPC calls. The app host's resource service validates that the expected key is received and rejects requests where the key is omitted.

* Remove test's exposure to ambient environment variables

* Review feedback

* Require authenticated user

* Renaming
…waiting for dashboard logs configurable - Disable all dashboard logging by default - Allow config override for default logging categories - Added tests (dotnet#3598)
…build 0.2.2 (dotnet#3592)

Microsoft.DeveloperControlPlane.darwin-amd64 , Microsoft.DeveloperControlPlane.darwin-arm64 , Microsoft.DeveloperControlPlane.linux-amd64 , Microsoft.DeveloperControlPlane.linux-arm64 , Microsoft.DeveloperControlPlane.windows-386 , Microsoft.DeveloperControlPlane.windows-amd64 , Microsoft.DeveloperControlPlane.windows-arm64
 From Version 0.2.1 -> To Version 0.2.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Fix validation error messages

Looks like a copy/paste bug. It could mislead a user who is trying to configure the dashboard correctly.

* Handle missing configuration values

* Review feedback

* Fix build error after merging multiple PRs (dotnet#3589)

---------

Co-authored-by: Drew Noakes <git@drewnoakes.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
…3606)

* Exclude the dashboard from the manifest when its a project - Added a test

* Fix test

---------

Co-authored-by: David Fowler <davidfowl@gmail.com>
…et#3619)

Adds optional configuration that checks a given claim of a user authenticated via OIDC.

Two new configuration values are:

- `Dashboard:Frontend:OpenIdConnect:RequireClaimType` specifies the (optional) claim that be present for authorized users. Defaults to empty.
- `Dashboard:Frontend:OpenIdConnect:RequireClaimValue` specifies the (optional) value of the required claim. Only used if `Dashboard:Frontend:OpenIdConnect:RequireClaimType` is also specified. Defaults to empty.

Co-authored-by: Drew Noakes <git@drewnoakes.com>
1. Set the transport to be http2 on the grpc endpoint
2. Use the Url property in the connection string for simplicity

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
* Add tooltips to Resource table

* De-dupe source column code

---------

Co-authored-by: Adam Ratzman <adamratzman@microsoft.com>
…net#3623)

* [tests] Use ResiliencePipeline in IntegrationTests

.. with a policy to retry with 1 sec delays, and a total timeout of
90 secs on the service side. The test(client) side has an overall http
request timeout for 120 secs which would allow the real errors from the
service to get surfaced to the client.

* address review feedback from @ eerhardt

* Use the pipeline for MySql also

* IntegrationServiceFixture.DumpComponentLogsAsync: error out if more than one resource is given

* Rename TestUtils -> ResilienceUtils - feedback from @ eerhardt

* [tests] Ignore `CA1305` for tests

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1305

```
dotnet_diagnostic.CA1305.severity = none
```

Addresses review feedback from @ eerhardt .

* Remove Polly reference

* Make code consistent.

* add comment addressing review feedback from @ eerhardt

---------

Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…ests (dotnet#3621)

* [tests] Extract support for running an aspire app for tests

.. to `tests/Shared/WorkloadTesting/AspireProject.cs`, so it can be used
by other tests too.

* Address review feedback from @ eerhardt

- Rename `AspireProject.Process` to `AspireProject.AppHostProcess`
- remove nuget8.config which isn't needed yet

* Update tests/Aspire.EndToEnd.Tests/IntegrationServicesTests.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

* address review feedback from @ eerhardt

* Address review feedback from @ eerhardt, and remove some duplication

---------

Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…otnet#3184) (dotnet#3626)

* dapr change the app port depending on the app protocol

* fix endpoint annotations for dapr.

* fix the rest of the endpoints uri schemas

* Apply suggestions from code review



* fix white spaces

* now we can define both, dapr protocol or endpoint from the configured endpoint

* add tests

* revert changes in the playground

* fix spelling issue

* add a large comment for all of this logic

* fix formatting

* Update src/Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs

* change to switch expression fix test

* revert changes in playground

* format stuff

* fix is null and formating

* improve switch

---------

Co-authored-by: paule96 <paul-jeschke@outlook.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Ensures these icons are differentiated not only by colour, but also by icon.

Co-authored-by: Drew Noakes <git@drewnoakes.com>
Co-authored-by: Drew Noakes <git@drewnoakes.com>
Co-authored-by: Tim Mulholland <timulhol@microsoft.com>
…#3622)

Currently, `tests/send-to-helix.proj` builds once and constructs various
`@(HelixWorkItem)`s for end-to-end tests, and basic tests that don't
need a workload.

Because of the way Helix SDK works, this ends up sharing some stuff like
`HelixPreCommand`, and `HelixPostCommand`. But the different kinds of
tests don't need the same pre/post commands, and the targets need to be
careful not to step on each other's items/properties.

To avoid all this, and keep it clean a new top-level project
`tests/send-to-helix-ci.proj` is added which essentially builds the
existing project multiple times, once for each test type (called Test
Category here).

Thus you have:

```
send-to-helix-ci.proj runs the following in parallel:
    => send-to-helix-inner.proj testCategory=basictests
        -> send, and wait for the helix jobs
    => send-to-helix-inner.proj testCategory=endtoendtests
        -> send, and wait for the helix jobs
```

Co-authored-by: Ankit Jain <radical@gmail.com>
…cutable, the logic we used to detect replics in broken. Instead of trying to be clever, watch all dashboard resources and log their output. This is more robust and future proof as we only have one dashboard running at once. - Deleted the timeout (dotnet#3637)
* Fix broken find token image in HTTP

* Fix

---------

Co-authored-by: James Newton-King <james@newtonking.com>
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 12, 2024
@danmoseley
Copy link
Member Author

gh tool did odd thing...

@danmoseley danmoseley closed this Apr 12, 2024
@danmoseley danmoseley deleted the azure.identity.bump branch April 12, 2024 16:53
@danmoseley danmoseley restored the azure.identity.bump branch April 12, 2024 16:54
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Azure SignalR hosting readme to note ConnectionString usage and client methods to use