Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview5] Always use the old protocol #3183

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 26, 2024

Backport of #3182 to release/8.0-preview5

/cc @davidfowl

Customer Impact

Without this change, using Aspire will in an IDE will break until that IDE is updated to use the brand-new protocol invented in this release (that breaks VS, and Rider). This change reverts to using the old protocol unconditionally until the new protocol exists in those IDEs.

Testing

Manual. Tested this change with both current VS (public preview) and new VS (internal preview).

Risk

Low

… IDE protocol version, so use the old protocol until then.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 26, 2024
@davidfowl davidfowl merged commit a45180e into release/8.0-preview5 Mar 26, 2024
7 checks passed
@davidfowl davidfowl deleted the backport/pr-3182-to-release/8.0-preview5 branch March 26, 2024 17:40
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants