[release/8.0] Add token auth to dashboard frontend #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JamesNK
requested review from
davidfowl,
DamianEdwards,
JamesNK,
drewnoakes,
mitchdenny,
joperezr,
adamint and
kvenkatrajan
JamesNK
approved these changes
Apr 3, 2024
|
@JamesNK for the token example screenshot, did you try it at different screen resolutions and/or scaling? I'm wondering what it looks like on screens with higher DPI/scaling ratios set as this is often requires multiple image files to ensure it doesn't look super pixelated at higher DPIs. |
|
Sort of related, @kvenkatrajan I'm assuming you are tracking accessibility testing on these new views? |
|
The screenshot (and help popup in general) isn't 100% yet. Don't block merging this on it being perfect. Remaining work for help popup here: #3348 |
JamesNK
added
Servicing-approved
eerhardt
reviewed
Apr 4, 2024
eerhardt
reviewed
Apr 4, 2024
|
@eerhardt PR updated. |
eerhardt
approved these changes
Apr 4, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3213 to release/8.0
/cc @JamesNK
Customer Impact
Required authentication to secure the local dashboard experience.
Testing
Unit testing. Manual smoke testing branch that auth is successfully working.
Risk
Medium-High. Lots of changes.
Microsoft Reviewers: Open in CodeFlow