Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Re-enables IDE protocol v1 support. #3411

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 4, 2024

Backport of #3269 to release/8.0

/cc @danegsta @karolz-ms

Customer Impact

Enables support for the new V1 IDE protocol when it rolls out in VS/VSCode. Without this change, Aspire debugging won't work with any IDE implementing the V1 protocol.

Testing

This has been enabled in main for several days and has been working with the current IDE protocol and been tested against the V1 protocol as well.

Risk

Low

Microsoft Reviewers: Open in CodeFlow

…make it tolerate any combination of IDE tooling and app host libraries. That is, DCP will be able to use both old and new-style annotations and will probe the IDE for protocol supported, translating the requests as necessary.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 4, 2024
@dbreshears dbreshears self-requested a review April 5, 2024 16:25
@joperezr joperezr added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 5, 2024
@joperezr
Copy link
Member

joperezr commented Apr 5, 2024

Approved in chat.

@joperezr joperezr merged commit 8254040 into release/8.0 Apr 5, 2024
7 checks passed
@joperezr joperezr deleted the backport/pr-3269-to-release/8.0 branch April 5, 2024 17:00
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants