Re-enables IDE protocol v1 support. #3269
Conversation
dotnet-issue-labeler
bot
added
the
area-app-model
|
@mitchdenny meant to ask you for review as well but for some reason GH is not letting me... 😕 |
|
@karolz-ms did you try this with public VS? If not I can before merging. |
|
@davidfowl I have not yet. Would very much appreciate a check from you |
|
We need this change in preview 6 right? |
davidfowl
added
the
NO-MERGE
dotnet-policy-service
bot
added
the
needs-author-action
|
Is the new DCP in already? Does it handle old pre v1 protocol requests? |
|
This change requires DCP version 0.1.62, which has been stuck in the pipeline since two days ago due to some AzDO issues... 😞 |
dotnet-policy-service
bot
removed
the
needs-author-action
Corresponding change in DCP will make it tolerate any combination of IDE tooling and app host libraries. That is, DCP will be able to use both old and new-style annotations and will probe the IDE for protocol supported, translating the requests as necessary.
karolz-ms
force-pushed
the
dev/karolz/reenable-ide-v1-protocol
branch
from
9574cc8 to
8668aca
Compare
|
I verified that with the new DCP and VS 2022 17.10.0 Preview 2.0 (NOT IntPreview) the TestShop app still works with this change. So we just need to wait for the DCP insertion and then we can merge. |
|
Verified again this morning with DCP 0.1.62 that was integrated into Aspire main over the weekend, works with publicly available VS 2022 Preview |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8562282218 |
Corresponding change in DCP will make it tolerate any combination of IDE tooling and app host libraries. That is, DCP will be able to use both old and new-style annotations and will probe the IDE for protocol supported, translating the requests as necessary.
Microsoft Reviewers: Open in CodeFlow