Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Generate and store random RG name when provisioning #3508

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 9, 2024

Backport of #3375 to release/8.0

/cc @davidfowl @sebastienros

Customer Impact

Deployments are using the machine name in the resource group name. This change uses a random number and stores the created resource group name in user secrets.

Testing

Manual validation of:

  • New deployments use the random values
  • New deployments can use the custom RG name and won't have any random value
  • New deployments can use a custom RG prefix and a random value
  • New deployments with random values are stored in user secrets
  • Existing resource group name is reused from user secrets

Risk

Low. Users can also still force a custom resource group name.

Regression?

No.

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 9, 2024
@danmoseley danmoseley merged commit 8cac9f3 into release/8.0 Apr 10, 2024
7 checks passed
@danmoseley danmoseley deleted the backport/pr-3375-to-release/8.0 branch April 10, 2024 21:53
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication Servicing-consider Issue for next servicing release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants