[release/8.0] Fix validation error messages #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Looks like a copy/paste bug. It could mislead a user who is trying to configure the dashboard correctly.
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
added
Servicing-approved
|
approved |
|
@drewnoakes I picked up the other PR and the build break fix. So undraftified. Does this look right now? |
|
@danmoseley thank you for doing that. This looks good to me. |
drewnoakes
approved these changes
Apr 11, 2024
RussKie
approved these changes
Apr 11, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3374 to release/8.0
/cc @drewnoakes
Customer Impact
We aim to have helpful error messages to guide customers towards the correct configuration of the dashboard.
Previously, customers attempting to configure security settings for the dashboard would see erroneous error messages which would be misleading and confusing. This PR fixes those messages.
Testing
Manual testing.
Risk
Low. This is just changing error strings.
There's one additional case added, for when the certificate source is not provided.
Regression?
No.
Microsoft Reviewers: Open in CodeFlow