Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error after merging multiple PRs #3589

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Apr 11, 2024

This was renamed in one PR, and the old name used in another PR. Merging both led to compilation failures.

Microsoft Reviewers: Open in CodeFlow

@drewnoakes drewnoakes enabled auto-merge (squash) April 11, 2024 04:05
@danmoseley
Copy link
Member

build locally

@danmoseley danmoseley disabled auto-merge April 11, 2024 04:06
@danmoseley danmoseley merged commit 62e130a into dotnet:main Apr 11, 2024
2 of 6 checks passed
@drewnoakes drewnoakes deleted the fix-build branch April 11, 2024 04:06
RussKie pushed a commit that referenced this pull request Apr 11, 2024
* Fix validation error messages

Looks like a copy/paste bug. It could mislead a user who is trying to configure the dashboard correctly.

* Handle missing configuration values

* Review feedback

* Fix build error after merging multiple PRs (#3589)

---------

Co-authored-by: Drew Noakes <git@drewnoakes.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants