[release/8.0] Explicitly specify grpc OTLP protocol with env var #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
JamesNK
approved these changes
Apr 5, 2024
danmoseley
added
Servicing-approved
joperezr
approved these changes
Apr 5, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3384 to release/8.0
/cc @JamesNK
Customer Impact
The dashboard only supports OTLP over gRPC. Most SDK's OTLP exporters default to gRPC but we should be explicit in case there are exporters that prefer another protocol. We want them to use grpc.
There was a customer report of Python using Protobuf/JSON over HTTP. That failed because the dashboard doesn't support it.
Testing
Unit testing and manual testing.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow