[release/8.0] Change starter template to make frontend external endpoints #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-policy-service
bot
added
the
Servicing-consider
eerhardt
approved these changes
Apr 10, 2024
danmoseley
added
Servicing-approved
danmoseley
approved these changes
Apr 10, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3514 to release/8.0
/cc @eerhardt @timheuer
Customer Impact
When devs use the starter template and deploy it using
azd, the frontend web app end isn't accessible. So they can't see their app running.Testing
Manual validation of:
Risk
Low. Just adds the WithExternalHttpEndpoints call to the template.
Regression?
Yes. Before the endpoint refactoring,
azdwould prompt which endpoints to make external. Now it doesn't prompt, and the web app isn't accessible after publishing.Microsoft Reviewers: Open in CodeFlow