[release/8.0] [tests] Improve building+sending tests to helix #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Currently, `tests/send-to-helix.proj` builds once and constructs various
`@(HelixWorkItem)`s for end-to-end tests, and basic tests that don't
need a workload.
Because of the way Helix SDK works, this ends up sharing some stuff like
`HelixPreCommand`, and `HelixPostCommand`. But the different kinds of
tests don't need the same pre/post commands, and the targets need to be
careful not to step on each other's items/properties.
To avoid all this, and keep it clean a new top-level project
`tests/send-to-helix-ci.proj` is added which essentially builds the
existing project multiple times, once for each test type (called Test
Category here).
Thus you have:
```
send-to-helix-ci.proj runs the following in parallel:
=> send-to-helix-inner.proj testCategory=basictests
-> send, and wait for the helix jobs
=> send-to-helix-inner.proj testCategory=endtoendtests
-> send, and wait for the helix jobs
```
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
added
Servicing-approved
|
infra/tests only. auto approved |
radical
approved these changes
Apr 12, 2024
danmoseley
approved these changes
Apr 12, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3496 to release/8.0
/cc @radical
Customer Impact
Testing
Risk
Regression?
Microsoft Reviewers: Open in CodeFlow