[release/8.0-preview5] Add README file for Aspire.Hosting.AWS #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-app-model
davidfowl
approved these changes
Mar 28, 2024
|
|
||
| ## Provisioning application resources with AWS CloudFormation | ||
|
|
||
| AWS application resources like Amazon DynamoDB tables or Amazon Simple Queue Service (SQS) queues can be provisioning during AppHost |
There was a problem hiding this comment.
Suggested change
| AWS application resources like Amazon DynamoDB tables or Amazon Simple Queue Service (SQS) queues can be provisioning during AppHost | |
| AWS application resources like Amazon DynamoDB tables or Amazon Simple Queue Service (SQS) queues can be provisioned during AppHost |
| "Type" : "AWS::SNS::Topic", | ||
| "Properties" : { | ||
| "Subscription" : [ | ||
| {"Protocol" : "sqs", "Endpoint" : {"Fn::GetAtt" : [ "ChatMessagesQueue", "Arn"]}} |
There was a problem hiding this comment.
Suggested change
| {"Protocol" : "sqs", "Endpoint" : {"Fn::GetAtt" : [ "ChatMessagesQueue", "Arn"]}} | |
| { "Protocol" : "sqs", "Endpoint" : { "Fn::GetAtt" : [ "ChatMessagesQueue", "Arn" ] } } |
|
@DamianEdwards My ignorance on the process here. Since my PR that added the README file has already been merged and this is the PR to backport I assume I don't have permissions to edit the |
|
Yep do it main |
normj
added a commit
to normj/aspire
that referenced
this pull request
Mar 28, 2024
Done: #3248 |
davidfowl
pushed a commit
that referenced
this pull request
Mar 28, 2024
DamianEdwards
approved these changes
Mar 28, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3234 to release/8.0-preview5
/cc @davidfowl @normj
Customer Impact
Adding AWS package readme.
Testing
None
Risk
Low
Microsoft Reviewers: Open in CodeFlow