[release/8.0-preview5] Backport of 3177 (ASPIRE_ALLOW_UNSECURED_TRANSPORT) #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RE_ALLOW_UNSECURED_TRANSPORT is not set (#3177)
dotnet-issue-labeler
bot
added
the
needs-area-label
mitchdenny
added
the
area-app-model
davidfowl
approved these changes
Mar 28, 2024
JamesNK
approved these changes
Mar 28, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3177 to release/8.0-preview5
/cc @eerhardt
Customer Impact
Forces the use of HTTPS for ASPNETCORE_URLS, DOTNET_DASHBOARD_OTLP_ENDPOINT_URL, DOTNET_RESOURCE_SERVICE_ENDPOINT_URL environment variables/config settings UNLESS the ASPIRE_ALLOW_UNSECURED_TRANSPORT variable is set to true, or the dashboard is disabled via options.
Testing
Automated tests pass. Added 100% coverage for the validation logic as well as manual testing.
Risk
Moderate. This is an intentional breaking change in P5 which will require people to add configuration to their launch settings if they have existing projects. Tempaltes were previously updated to satisfy these new validation rules. The thinking is that we want people to take this pain down to ease P6 and GA adoption.