Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Add additional project template string #3287

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 29, 2024

Backport of #3286 to release/8.0

/cc @tlmii

Customer Impact

Testing

Risk

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DamianEdwards can correct me if I'm wrong, but I don't think this is the file where these changes go. We should be changing the template.json and then building the repo which will automatically update all of the localize templatestrings files.

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, nvm just saw the discussion in the main PR and understand why we are updating this. Thanks @tlmii

@DamianEdwards DamianEdwards merged commit 1075e57 into release/8.0 Apr 1, 2024
7 checks passed
@DamianEdwards DamianEdwards deleted the backport/pr-3286-to-release/8.0 branch April 1, 2024 18:24
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants