Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Fix dashboard token being written on publish #3418

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 4, 2024

Backport of #3391 to release/8.0

/cc @JamesNK

Customer Impact

The dashboard login address is written to console when publishing manifest. Customers will be confused.

Testing

Manual testing

Risk

Low

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 4, 2024
@JamesNK JamesNK added Servicing-approved Approved for servicing release Servicing-consider Issue for next servicing release review and removed Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release labels Apr 5, 2024
@JamesNK JamesNK added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 7, 2024
@davidfowl davidfowl merged commit 9a89cbf into release/8.0 Apr 7, 2024
7 checks passed
@davidfowl davidfowl deleted the backport/pr-3391-to-release/8.0 branch April 7, 2024 23:39
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants