[release/8.0] dapr change the app port depending on the app protocol #3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dapr change the app port depending on the app protocol * fix endpoint annotations for dapr. * fix the rest of the endpoints uri schemas * Apply suggestions from code review Co-authored-by: David Fowler <davidfowl@gmail.com> * fix white spaces * now we can define both, dapr protocol or endpoint from the configured endpoint * add tests * revert changes in the playground * fix spelling issue * add a large comment for all of this logic * fix formatting * Update src/Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs * change to switch expression fix test * revert changes in playground * format stuff * fix is null and formating * improve switch --------- Co-authored-by: David Fowler <davidfowl@gmail.com>
dotnet-issue-labeler
bot
added
the
area-codeflow
dotnet-policy-service
bot
added
the
Servicing-consider
|
Where did we end up with using HTTPS by default as well? Separate issue? |
danmoseley
added
Servicing-approved
|
approved for obvious reasons. |
danmoseley
approved these changes
Apr 11, 2024
danmoseley
added
area-app-model
Needs more design, post GA. |
davidfowl
approved these changes
Apr 12, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backpoirt #3184 to release/8.0
Fixes #2367
Customer Impact
Described in #2367. Basically, if a DAPR-enabled Aspire app uses anything other than HTTP for communication, it will fail to communicate with the DAPR sidecar, so pretty bad.
Testing
@paule96 did manual testing and added pretty comprehensive automated test coverage of the change.
Risk
Low IMO. The change is well localized and small.
Regression
Not really--the initial implementation of the feature only covered HTTP case
Microsoft Reviewers: Open in CodeFlow